]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
conf: add missing break in virDomainAuditRedirdev
authorMarc-André Lureau <marcandre.lureau@gmail.com>
Wed, 14 Sep 2011 20:02:30 +0000 (22:02 +0200)
committerEric Blake <eblake@redhat.com>
Wed, 14 Sep 2011 21:30:32 +0000 (15:30 -0600)
Also initialize to NULL a few variables that might get
free before being set.

src/conf/domain_audit.c

index 3d079bd8406fbca42d150b66bfaa9b771f7e516b..581be7046dd1a558f94986bd15be916a60c6eec8 100644 (file)
@@ -246,8 +246,8 @@ virDomainAuditHostdev(virDomainObjPtr vm, virDomainHostdevDefPtr hostdev,
 {
     char uuidstr[VIR_UUID_STRING_BUFLEN];
     char *vmname;
-    char *address;
-    char *device;
+    char *address = NULL;
+    char *device = NULL;
     const char *virt;
 
     virUUIDFormat(vm->def->uuid, uuidstr);
@@ -319,8 +319,8 @@ virDomainAuditRedirdev(virDomainObjPtr vm, virDomainRedirdevDefPtr redirdev,
 {
     char uuidstr[VIR_UUID_STRING_BUFLEN];
     char *vmname;
-    char *address;
-    char *device;
+    char *address = NULL;
+    char *device = NULL;
     const char *virt;
 
     virUUIDFormat(vm->def->uuid, uuidstr);
@@ -340,6 +340,7 @@ virDomainAuditRedirdev(virDomainObjPtr vm, virDomainRedirdevDefPtr redirdev,
             VIR_WARN("OOM while encoding audit message");
             goto cleanup;
         }
+        break;
     default:
         VIR_WARN("Unexpected redirdev bus while encoding audit message: %d",
                  redirdev->bus);