]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
scsi: ufs: core: Move an assignment in ufshcd_mcq_process_cqe()
authorBart Van Assche <bvanassche@acm.org>
Fri, 31 Oct 2025 20:39:16 +0000 (13:39 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 12 Nov 2025 22:02:31 +0000 (17:02 -0500)
Since 'tag' is only used inside the if-statement, move the 'tag'
assignment into the if-statement. This patch prepares for introducing a
WARN_ON_ONCE() call in ufshcd_mcq_get_tag() if the tag lookup fails.

Reviewed-by: Avri Altman <avri.altman@sandisk.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://patch.msgid.link/20251031204029.2883185-9-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/ufs/core/ufs-mcq.c

index d04662b57cd19bbdca96bccfdec4d5aa27e2cf0e..bae35d0f99c5b0144ca5afa09d460beffbaf824e 100644 (file)
@@ -307,9 +307,10 @@ static void ufshcd_mcq_process_cqe(struct ufs_hba *hba,
                                   struct ufs_hw_queue *hwq)
 {
        struct cq_entry *cqe = ufshcd_mcq_cur_cqe(hwq);
-       int tag = ufshcd_mcq_get_tag(hba, cqe);
 
        if (cqe->command_desc_base_addr) {
+               int tag = ufshcd_mcq_get_tag(hba, cqe);
+
                ufshcd_compl_one_cqe(hba, tag, cqe);
                /* After processed the cqe, mark it empty (invalid) entry */
                cqe->command_desc_base_addr = 0;