]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: hns3: add \n at the end when print msg
authorPeiyang Wang <wangpeiyang1@huawei.com>
Mon, 23 Jun 2025 04:00:40 +0000 (12:00 +0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 25 Jun 2025 00:09:22 +0000 (17:09 -0700)
To make the print message more clearly, add \n at the and of message if
it is missing currently.

Signed-off-by: Peiyang Wang <wangpeiyang1@huawei.com>
Signed-off-by: Jijie Shao <shaojijie@huawei.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250623040043.857782-5-shaojijie@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c

index 208a2dfc07ec827aba1f1881b4f89519e720bd32..dc1e159264820fa2c8a3d49e941fa7100ec6b528 100644 (file)
@@ -2447,7 +2447,7 @@ static int hns3_nic_set_features(struct net_device *netdev,
        if ((netdev->features & NETIF_F_HW_TC) > (features & NETIF_F_HW_TC) &&
            h->ae_algo->ops->cls_flower_active(h)) {
                netdev_err(netdev,
-                          "there are offloaded TC filters active, cannot disable HW TC offload");
+                          "there are offloaded TC filters active, cannot disable HW TC offload\n");
                return -EINVAL;
        }
 
index c590daad497ca50d4b44dd166080a35a015a48b0..c615834dfd84731cb74c30c5e3458196fa7ca569 100644 (file)
@@ -436,7 +436,7 @@ static void hns3_self_test(struct net_device *ndev,
                data[i] = HNS3_NIC_LB_TEST_UNEXECUTED;
 
        if (hns3_nic_resetting(ndev)) {
-               netdev_err(ndev, "dev resetting!");
+               netdev_err(ndev, "dev resetting!\n");
                goto failure;
        }
 
@@ -794,7 +794,7 @@ static int hns3_get_link_ksettings(struct net_device *netdev,
                break;
        default:
 
-               netdev_warn(netdev, "Unknown media type");
+               netdev_warn(netdev, "Unknown media type\n");
                return 0;
        }
 
@@ -842,7 +842,7 @@ static int hns3_check_ksettings_param(const struct net_device *netdev,
        if (cmd->base.duplex == DUPLEX_HALF &&
            media_type != HNAE3_MEDIA_TYPE_COPPER) {
                netdev_err(netdev,
-                          "only copper port supports half duplex!");
+                          "only copper port supports half duplex!\n");
                return -EINVAL;
        }
 
@@ -1321,7 +1321,7 @@ static int hns3_nway_reset(struct net_device *netdev)
                return 0;
 
        if (hns3_nic_resetting(netdev)) {
-               netdev_err(netdev, "dev resetting!");
+               netdev_err(netdev, "dev resetting!\n");
                return -EBUSY;
        }
 
@@ -1937,7 +1937,7 @@ static int hns3_set_tunable(struct net_device *netdev,
        int i, ret = 0;
 
        if (hns3_nic_resetting(netdev) || !priv->ring) {
-               netdev_err(netdev, "failed to set tunable value, dev resetting!");
+               netdev_err(netdev, "failed to set tunable value, dev resetting!\n");
                return -EBUSY;
        }
 
index 5acefd57df45e7c17586a57e783c6bea91629021..205cdbb817434f3f504236fbc6c5836502ae819b 100644 (file)
@@ -11423,7 +11423,7 @@ static int hclge_pci_init(struct hclge_dev *hdev)
                ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
                if (ret) {
                        dev_err(&pdev->dev,
-                               "can't set consistent PCI DMA");
+                               "can't set consistent PCI DMA\n");
                        goto err_disable_device;
                }
                dev_warn(&pdev->dev, "set DMA mask to 32 bits\n");
index f1657f50cdda36e6f5a755017b1394e7bcdcc6b1..ffe51a68384c822a3d80814d09d8452b6421ffb7 100644 (file)
@@ -2625,7 +2625,7 @@ static int hclgevf_pci_init(struct hclgevf_dev *hdev)
 
        ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
        if (ret) {
-               dev_err(&pdev->dev, "can't set consistent PCI DMA, exiting");
+               dev_err(&pdev->dev, "can't set consistent PCI DMA, exiting\n");
                goto err_disable_device;
        }