gitlab-ci: Fix only: variables: check, and quote variables.

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 3e59a7ced07c613678065f5845c8f102130e9170..7d3574b82b88b59c42e5369c4e1e6b11dea9ae88 100644 (file)
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -179,7 +179,7 @@ remote/s390x:
   before_script:
   # File created as world-readable by gitlab ci machinery.
   - chmod 0600 $SSH_PRIVATE_KEY
-  - ssh -o 'StrictHostKeyChecking no' -i $SSH_PRIVATE_KEY $S390X_ACCOUNT
+  - ssh -o 'StrictHostKeyChecking no' -i "$SSH_PRIVATE_KEY" "$S390X_ACCOUNT"
     "mkdir -p ci-work/$CI_PIPELINE_IID"
   script:
   - echo $CI_PIPELINE_IID
@@ -187,21 +187,21 @@ remote/s390x:
     ./configure && make PACKAGE_VERSION=snapshot dist &&
       ls -l *.tar.gz
   - cat nettle-snapshot.tar.gz |
-    ssh -o 'StrictHostKeyChecking no' -i $SSH_PRIVATE_KEY $S390X_ACCOUNT
+    ssh -o 'StrictHostKeyChecking no' -i "$SSH_PRIVATE_KEY" "$S390X_ACCOUNT"
     "cd ci-work/$CI_PIPELINE_IID && tar xzf -"
-  - ssh -o 'StrictHostKeyChecking no' -i $SSH_PRIVATE_KEY $S390X_ACCOUNT
+  - ssh -o 'StrictHostKeyChecking no' -i "$SSH_PRIVATE_KEY" "$S390X_ACCOUNT"
     "cd ci-work/$CI_PIPELINE_IID/nettle-snapshot && ./configure --disable-documentation"
-  - ssh -o 'StrictHostKeyChecking no' -i $SSH_PRIVATE_KEY $S390X_ACCOUNT
+  - ssh -o 'StrictHostKeyChecking no' -i "$SSH_PRIVATE_KEY" "$S390X_ACCOUNT"
     "cd ci-work/$CI_PIPELINE_IID/nettle-snapshot && make"
-  - ssh -o 'StrictHostKeyChecking no' -i $SSH_PRIVATE_KEY $S390X_ACCOUNT
+  - ssh -o 'StrictHostKeyChecking no' -i "$SSH_PRIVATE_KEY" "$S390X_ACCOUNT"
     "cd ci-work/$CI_PIPELINE_IID/nettle-snapshot && make check"
   after_script:
-  - ssh -o 'StrictHostKeyChecking no' -i $SSH_PRIVATE_KEY $S390X_ACCOUNT
+  - ssh -o 'StrictHostKeyChecking no' -i "$SSH_PRIVATE_KEY" "$S390X_ACCOUNT"
     "rm -rf ci-work/$CI_PIPELINE_IID"
   only:
     variables:
-    - $SSH_PRIVATE_KEY
-    - $S390X_ACCOUNT
+    - $SSH_PRIVATE_KEY != ""
+    - $S390X_ACCOUNT != ""
   tags:
   - shared
   - linux