]> git.ipfire.org Git - thirdparty/knot-resolver.git/commitdiff
daemon/session2/session2_transport_event(): remove kr_fails_assert
authorFrantisek Tobias <frantisek.tobias@nic.cz>
Tue, 20 Jan 2026 17:20:54 +0000 (18:20 +0100)
committerFrantisek Tobias <frantisek.tobias@nic.cz>
Wed, 21 Jan 2026 13:32:03 +0000 (14:32 +0100)
When forwarding over DoT, an upstream that accepts a TCP connection
and immediately closes it triggers this assetion, because
the forwarder wasn't able to solve any waiting tasks.

daemon/session2.c

index 970e07a937fdfcf2a7efb185d976f1122e5227af..4052b202a589d7775962052df18feff8b3540fa2 100644 (file)
@@ -1756,10 +1756,8 @@ static int session2_transport_event(struct session2 *s,
        bool is_close_event = (event == PROTOLAYER_EVENT_CLOSE ||
                        event == PROTOLAYER_EVENT_FORCE_CLOSE);
        if (is_close_event) {
-               if (kr_fails_assert(session2_is_empty(s))) {
-                       session2_waitinglist_finalize(s, KR_STATE_FAIL);
-                       session2_tasklist_finalize(s, KR_STATE_FAIL);
-               }
+               session2_waitinglist_finalize(s, KR_STATE_FAIL);
+               session2_tasklist_finalize(s, KR_STATE_FAIL);
                session2_timer_stop(s);
                s->closing = true;
        }