Revert "domain_conf: Introduce VIR_DOMAIN_DEF_PARSE_SKIP_POST_PARSE"

This breaks vCPU hotplug, because when starting a domain, we
create a copy of domain definition (which becomes live XML) and
during the post parse callbacks we might adjust some tunings so
that vCPU hotplug is possible.

This reverts commit c0f90799bc7fa4b690ead6a592806378a243873c.

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 920529a76d6c1a57476cd658ac8234ffb35c369e..1e65df13928fd6b216a7c6fc897202abbec95ef7 100644 (file)
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -4430,9 +4430,6 @@ virDomainDeviceDefPostParse(virDomainDeviceDefPtr dev,
 {
     int ret;
 
-    if (flags & VIR_DOMAIN_DEF_PARSE_SKIP_POST_PARSE)
-        return 0;
-
     if (xmlopt->config.devicesPostParseCallback) {
         ret = xmlopt->config.devicesPostParseCallback(dev, def, caps, flags,
                                                       xmlopt->config.priv,
@@ -4582,9 +4579,6 @@ virDomainDefPostParse(virDomainDefPtr def,
         .parseOpaque = parseOpaque,
     };
 
-    if (parseFlags & VIR_DOMAIN_DEF_PARSE_SKIP_POST_PARSE)
-        return 0;
-
     /* this must be done before the hypervisor-specific callback,
      * in case presence of a controller at a specific index is checked
      */

diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index fd3ae8e5007d3851e2f4b6cba6448cab4fc07799..a70bc2182a48a65a2ff6dd99f72f51ea9adde740 100644 (file)
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -2647,8 +2647,6 @@ typedef enum {
     VIR_DOMAIN_DEF_PARSE_ABI_UPDATE = 1 << 9,
     /* skip definition validation checks meant to be executed on define time only */
     VIR_DOMAIN_DEF_PARSE_SKIP_VALIDATE = 1 << 10,
-    /* skip post parse callback */
-    VIR_DOMAIN_DEF_PARSE_SKIP_POST_PARSE = 1 << 11,
 } virDomainDefParseFlags;
 
 typedef enum {