]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
cpuidle: teo: Simplify handling of total events count
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 13 Jan 2025 18:50:23 +0000 (19:50 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 20 Jan 2025 16:17:56 +0000 (17:17 +0100)
Instead of computing the total events count from scratch every time,
decay it and add a PULSE value to it in teo_update().

No intentional functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Christian Loehle <christian.loehle@arm.com>
Tested-by: Aboorva Devarajan <aboorvad@linux.ibm.com>
Tested-by: Christian Loehle <christian.loehle@arm.com>
Link: https://patch.msgid.link/9388883.CDJkKcVGEf@rjwysocki.net
drivers/cpuidle/governors/teo.c

index d772a3b7ccbd78468e40abdb4ddf593b4e595ae0..600b54a9f1e1180b41d4b51f30131967a9bbff39 100644 (file)
@@ -189,8 +189,6 @@ static void teo_update(struct cpuidle_driver *drv, struct cpuidle_device *dev)
                }
        }
 
-       cpu_data->total = 0;
-
        /*
         * Decay the "hits" and "intercepts" metrics for all of the bins and
         * find the bins that the sleep length and the measured idle duration
@@ -202,8 +200,6 @@ static void teo_update(struct cpuidle_driver *drv, struct cpuidle_device *dev)
                bin->hits -= bin->hits >> DECAY_SHIFT;
                bin->intercepts -= bin->intercepts >> DECAY_SHIFT;
 
-               cpu_data->total += bin->hits + bin->intercepts;
-
                target_residency_ns = drv->states[i].target_residency_ns;
 
                if (target_residency_ns <= cpu_data->sleep_length_ns) {
@@ -228,6 +224,7 @@ static void teo_update(struct cpuidle_driver *drv, struct cpuidle_device *dev)
                        cpu_data->tick_intercepts += PULSE;
        }
 
+       cpu_data->total -= cpu_data->total >> DECAY_SHIFT;
        cpu_data->total += PULSE;
 }