]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
comedi: pcm3724: Add sanity checks for I/O base address
authorIan Abbott <abbotti@mev.co.uk>
Fri, 30 Jan 2026 16:48:04 +0000 (16:48 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Apr 2026 13:49:40 +0000 (15:49 +0200)
The "pcm3724" driver uses an admin-supplied configuration option
(`it->options[0]`) to configure the I/O port base address of a PCM-3724
board.  It currently allows any base address to be configured but the
hardware only supports base addresses (configured by on-board DIP
switches) in the range 0 to 0x3F0 on 16-byte boundaries.

Add a sanity check to ensure the device is not configured at an
unsupported base address.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Link: https://patch.msgid.link/20260130170416.49994-40-abbotti@mev.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/comedi/drivers/pcm3724.c

index fb41de3baef83953d080d08a1e32cfe5cf524785..867bb5b3860a65d590c663f703b919b4c8590db8 100644 (file)
@@ -194,7 +194,8 @@ static int pcm3724_attach(struct comedi_device *dev,
        if (!priv)
                return -ENOMEM;
 
-       ret = comedi_request_region(dev, it->options[0], 0x10);
+       ret = comedi_check_request_region(dev, it->options[0], 0x10,
+                                         0, 0x3ff, 16);
        if (ret)
                return ret;