]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/panthor: Relax a check in panthor_sched_pre_reset()
authorBoris Brezillon <boris.brezillon@collabora.com>
Fri, 28 Nov 2025 08:48:40 +0000 (09:48 +0100)
committerBoris Brezillon <boris.brezillon@collabora.com>
Fri, 28 Nov 2025 09:17:44 +0000 (10:17 +0100)
Groups are only moved out of the runnable lists when
panthor_group_stop() is called or when they run out of jobs.
What should not happen though is having one group added to one of
the runnable list after reset.in_progress has been set to true, but
that's not something we can easily check, so let's just drop the
WARN_ON() in panthor_sched_pre_reset().

v2:
- Adjust explanation in commit message

v3:
- Collect R-b

v4:
- No changes

Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>
Reviewed-by: Steven Price <steven.price@arm.com>
Link: https://patch.msgid.link/20251128084841.3804658-7-boris.brezillon@collabora.com
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
drivers/gpu/drm/panthor/panthor_sched.c

index b834123a6560e981d1d504df608b0cf5e3213db0..1beddc175722f172c13e2ed985f0135a9badbf30 100644 (file)
@@ -2937,8 +2937,6 @@ void panthor_sched_pre_reset(struct panthor_device *ptdev)
         * new jobs while we're resetting.
         */
        for (i = 0; i < ARRAY_SIZE(sched->groups.runnable); i++) {
-               /* All groups should be in the idle lists. */
-               drm_WARN_ON(&ptdev->base, !list_empty(&sched->groups.runnable[i]));
                list_for_each_entry_safe(group, group_tmp, &sched->groups.runnable[i], run_node)
                        panthor_group_stop(group);
        }