media: hi556: Add missing '\n' to hi556 error messages

Many hi556 dev_err() error messages miss a terminating '\n', add
the missing '\n' to these.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>

diff --git a/drivers/media/i2c/hi556.c b/drivers/media/i2c/hi556.c
index c28eca2f86f601f35219a6203fe6bdb027c6703a..960d6c2d3d9326dadced3bb836258dc276ec18fd 100644 (file)
--- a/drivers/media/i2c/hi556.c
+++ b/drivers/media/i2c/hi556.c
@@ -719,7 +719,7 @@ static int hi556_write_reg_list(struct hi556 *hi556,
                                      r_list->regs[i].val);
                if (ret) {
                        dev_err_ratelimited(&client->dev,
-                                           "failed to write reg 0x%4.4x. error = %d",
+                                           "failed to write reg 0x%4.4x. error = %d\n",
                                            r_list->regs[i].address, ret);
                        return ret;
                }
@@ -926,7 +926,7 @@ static int hi556_identify_module(struct hi556 *hi556)
                return ret;
 
        if (val != HI556_CHIP_ID) {
-               dev_err(&client->dev, "chip id mismatch: %x!=%x",
+               dev_err(&client->dev, "chip id mismatch: %x!=%x\n",
                        HI556_CHIP_ID, val);
                return -ENXIO;
        }
@@ -1002,14 +1002,14 @@ static int hi556_start_streaming(struct hi556 *hi556)
        reg_list = &link_freq_configs[link_freq_index].reg_list;
        ret = hi556_write_reg_list(hi556, reg_list);
        if (ret) {
-               dev_err(&client->dev, "failed to set plls");
+               dev_err(&client->dev, "failed to set plls\n");
                return ret;
        }
 
        reg_list = &hi556->cur_mode->reg_list;
        ret = hi556_write_reg_list(hi556, reg_list);
        if (ret) {
-               dev_err(&client->dev, "failed to set mode");
+               dev_err(&client->dev, "failed to set mode\n");
                return ret;
        }
 
@@ -1021,7 +1021,7 @@ static int hi556_start_streaming(struct hi556 *hi556)
                              HI556_REG_VALUE_16BIT, HI556_MODE_STREAMING);
 
        if (ret) {
-               dev_err(&client->dev, "failed to set stream");
+               dev_err(&client->dev, "failed to set stream\n");
                return ret;
        }
 
@@ -1034,7 +1034,7 @@ static void hi556_stop_streaming(struct hi556 *hi556)
 
        if (hi556_write_reg(hi556, HI556_REG_MODE_SELECT,
                            HI556_REG_VALUE_16BIT, HI556_MODE_STANDBY))
-               dev_err(&client->dev, "failed to set stream");
+               dev_err(&client->dev, "failed to set stream\n");
 }
 
 static int hi556_set_stream(struct v4l2_subdev *sd, int enable)
@@ -1229,25 +1229,25 @@ static int hi556_check_hwcfg(struct device *dev)
 
        ret = fwnode_property_read_u32(fwnode, "clock-frequency", &mclk);
        if (ret) {
-               dev_err(dev, "can't get clock frequency");
+               dev_err(dev, "can't get clock frequency\n");
                goto check_hwcfg_error;
        }
 
        if (mclk != HI556_MCLK) {
-               dev_err(dev, "external clock %d is not supported", mclk);
+               dev_err(dev, "external clock %d is not supported\n", mclk);
                ret = -EINVAL;
                goto check_hwcfg_error;
        }
 
        if (bus_cfg.bus.mipi_csi2.num_data_lanes != 2) {
-               dev_err(dev, "number of CSI2 data lanes %d is not supported",
+               dev_err(dev, "number of CSI2 data lanes %d is not supported\n",
                        bus_cfg.bus.mipi_csi2.num_data_lanes);
                ret = -EINVAL;
                goto check_hwcfg_error;
        }
 
        if (!bus_cfg.nr_of_link_frequencies) {
-               dev_err(dev, "no link frequencies defined");
+               dev_err(dev, "no link frequencies defined\n");
                ret = -EINVAL;
                goto check_hwcfg_error;
        }
@@ -1260,7 +1260,7 @@ static int hi556_check_hwcfg(struct device *dev)
                }
 
                if (j == bus_cfg.nr_of_link_frequencies) {
-                       dev_err(dev, "no link frequency %lld supported",
+                       dev_err(dev, "no link frequency %lld supported\n",
                                link_freq_menu_items[i]);
                        ret = -EINVAL;
                        goto check_hwcfg_error;
@@ -1334,7 +1334,7 @@ static int hi556_probe(struct i2c_client *client)
 
        ret = hi556_check_hwcfg(&client->dev);
        if (ret) {
-               dev_err(&client->dev, "failed to check HW configuration: %d",
+               dev_err(&client->dev, "failed to check HW configuration: %d\n",
                        ret);
                return ret;
        }
@@ -1372,7 +1372,7 @@ static int hi556_probe(struct i2c_client *client)
 
                ret = hi556_identify_module(hi556);
                if (ret) {
-                       dev_err(&client->dev, "failed to find sensor: %d", ret);
+                       dev_err(&client->dev, "failed to find sensor: %d\n", ret);
                        goto probe_error_power_off;
                }
        }
@@ -1381,7 +1381,7 @@ static int hi556_probe(struct i2c_client *client)
        hi556->cur_mode = &supported_modes[0];
        ret = hi556_init_controls(hi556);
        if (ret) {
-               dev_err(&client->dev, "failed to init controls: %d", ret);
+               dev_err(&client->dev, "failed to init controls: %d\n", ret);
                goto probe_error_v4l2_ctrl_handler_free;
        }
 
@@ -1392,13 +1392,13 @@ static int hi556_probe(struct i2c_client *client)
        hi556->pad.flags = MEDIA_PAD_FL_SOURCE;
        ret = media_entity_pads_init(&hi556->sd.entity, 1, &hi556->pad);
        if (ret) {
-               dev_err(&client->dev, "failed to init entity pads: %d", ret);
+               dev_err(&client->dev, "failed to init entity pads: %d\n", ret);
                goto probe_error_v4l2_ctrl_handler_free;
        }
 
        ret = v4l2_async_register_subdev_sensor(&hi556->sd);
        if (ret < 0) {
-               dev_err(&client->dev, "failed to register V4L2 subdev: %d",
+               dev_err(&client->dev, "failed to register V4L2 subdev: %d\n",
                        ret);
                goto probe_error_media_entity_cleanup;
        }