]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
clk: rk808: fix OF node reference imbalance
authorJohan Hovold <johan@kernel.org>
Tue, 7 Apr 2026 09:50:27 +0000 (11:50 +0200)
committerStephen Boyd <sboyd@kernel.org>
Wed, 29 Apr 2026 03:55:53 +0000 (20:55 -0700)
The driver reuses the OF node of the parent multi-function device but
fails to take another reference to balance the one dropped by the
platform bus code when unbinding the MFD and deregistering the child
devices.

Fix this by using the intended helper for reusing OF nodes.

Fixes: 2dc51ca822e4 ("clk: RK808: Reduce 'struct rk808' usage")
Cc: stable@vger.kernel.org # 6.5
Cc: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Reviewed-by: Brian Masney <bmasney@redhat.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/clk-rk808.c

index f7412b137e5ef4766254729621e9ce82eae29cb1..5a75b5c915551936c9350990831786673078fb4a 100644 (file)
@@ -153,7 +153,7 @@ static int rk808_clkout_probe(struct platform_device *pdev)
        struct rk808_clkout *rk808_clkout;
        int ret;
 
-       dev->of_node = pdev->dev.parent->of_node;
+       device_set_of_node_from_dev(dev, dev->parent);
 
        rk808_clkout = devm_kzalloc(dev,
                                    sizeof(*rk808_clkout), GFP_KERNEL);