]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
hw/core/loader: Free the allocated string from size_to_str()
authorAlistair Francis <alistair.francis@wdc.com>
Thu, 30 Oct 2025 01:53:06 +0000 (11:53 +1000)
committerAlistair Francis <alistair.francis@wdc.com>
Fri, 9 Jan 2026 05:01:09 +0000 (15:01 +1000)
The string needs be be freed with g_free() according to the functions
documentation.

Coverity: CID 1642762
Fixes: f62226f7dc44 ("hw/core/loader: improve error handling in image loading functions")
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20251030015306.2279148-3-alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
hw/core/loader.c

index 3d2c1ae286b118e38dd2e9fb1cae9c4341413a52..2fad7292e53cbc05b577b823ac961f899f85d97b 100644 (file)
@@ -153,8 +153,12 @@ ssize_t load_image_targphys_as(const char *filename,
     }
 
     if (size > max_sz) {
+        char *size_str = size_to_str(max_sz);
+
         error_setg(errp, "%s exceeds maximum image size (%s)",
-                   filename, size_to_str(max_sz));
+                   filename, size_str);
+
+        g_free(size_str);
         return -1;
     }