iio: xilinx-ams: Fix AMS_ALARM_THR_DIRECT_MASK

commit 1315cc2dbd5034f566e20ddce4d675cb9e6d4ddd upstream.

AMS_ALARM_THR_DIRECT_MASK should be bit 0, not bit 1. This would cause
hysteresis to be enabled with a lower threshold of -28C. The temperature
alarm would never deassert even if the temperature dropped below the
upper threshold.

Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver")
Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
Reviewed-by: O'Griofa, Conall <conall.ogriofa@amd.com>
Tested-by: Erim, Salih <Salih.Erim@amd.com>
Acked-by: Erim, Salih <Salih.Erim@amd.com>
Link: https://patch.msgid.link/20250715003058.2035656-1-sean.anderson@linux.dev
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/iio/adc/xilinx-ams.c b/drivers/iio/adc/xilinx-ams.c
index 3db021b96ae9d4e0d0e2b4d8d3cc8ac83e4e921c..024923cf46382424a1e797a2bcca3bf372715bd8 100644 (file)
--- a/drivers/iio/adc/xilinx-ams.c
+++ b/drivers/iio/adc/xilinx-ams.c
@@ -118,7 +118,7 @@
 #define AMS_ALARM_THRESHOLD_OFF_10     0x10
 #define AMS_ALARM_THRESHOLD_OFF_20     0x20
 
-#define AMS_ALARM_THR_DIRECT_MASK      BIT(1)
+#define AMS_ALARM_THR_DIRECT_MASK      BIT(0)
 #define AMS_ALARM_THR_MIN              0x0000
 #define AMS_ALARM_THR_MAX              (BIT(16) - 1)