]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: assign USB addresses on redirdev hotplug too
authorJán Tomko <jtomko@redhat.com>
Fri, 27 Jan 2017 14:26:13 +0000 (15:26 +0100)
committerJán Tomko <jtomko@redhat.com>
Mon, 30 Jan 2017 15:17:35 +0000 (16:17 +0100)
https://bugzilla.redhat.com/show_bug.cgi?id=1375410

src/qemu/qemu_hotplug.c

index a6de25407132090f1d0cb23f5130f3445e73a474..57ecc02e438431e1a121a8d531531f9a65037867 100644 (file)
@@ -1587,6 +1587,7 @@ int qemuDomainAttachRedirdevDevice(virConnectPtr conn,
     virJSONValuePtr secProps = NULL;
     char *tlsAlias = NULL;
     char *secAlias = NULL;
+    bool need_release = false;
     virErrorPtr orig_err;
 
     qemuDomainPrepareChardevSourceTLS(redirdev->source, cfg);
@@ -1597,6 +1598,11 @@ int qemuDomainAttachRedirdevDevice(virConnectPtr conn,
     if (!(charAlias = qemuAliasChardevFromDevAlias(redirdev->info.alias)))
         goto cleanup;
 
+    if ((rc = virDomainUSBAddressEnsure(priv->usbaddrs, &redirdev->info)) < 0)
+        goto cleanup;
+    if (rc == 1)
+        need_release = true;
+
     if (!(devstr = qemuBuildRedirdevDevStr(def, redirdev, priv->qemuCaps)))
         goto cleanup;
 
@@ -1649,6 +1655,8 @@ int qemuDomainAttachRedirdevDevice(virConnectPtr conn,
  audit:
     virDomainAuditRedirdev(vm, redirdev, "attach", ret == 0);
  cleanup:
+    if (ret < 0 && need_release)
+        qemuDomainReleaseDeviceAddress(vm, &redirdev->info, NULL);
     VIR_FREE(tlsAlias);
     virJSONValueFree(tlsProps);
     VIR_FREE(secAlias);