]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
phy: amlogic: phy-meson-axg-mipi-pcie-analog: Simplify error handling with dev_err_pr...
authorAnand Moon <linux.amoon@gmail.com>
Thu, 10 Apr 2025 13:33:18 +0000 (19:03 +0530)
committerVinod Koul <vkoul@kernel.org>
Fri, 11 Apr 2025 11:37:15 +0000 (17:07 +0530)
Use dev_err_probe() for phy resources to indicate the deferral
reason when waiting for the resource to come up.

Signed-off-by: Anand Moon <linux.amoon@gmail.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20250410133332.294556-4-linux.amoon@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c

index ae898f93f97b20ffc67b233ab6653cbb1456505a..c0ba2852dbb8e26d1207928d46666d47350e4261 100644 (file)
@@ -200,7 +200,6 @@ static int phy_axg_mipi_pcie_analog_probe(struct platform_device *pdev)
        struct phy_axg_mipi_pcie_analog_priv *priv;
        struct device_node *np = dev->of_node, *parent_np;
        struct regmap *map;
-       int ret;
 
        priv = devm_kmalloc(dev, sizeof(*priv), GFP_KERNEL);
        if (!priv)
@@ -219,12 +218,9 @@ static int phy_axg_mipi_pcie_analog_probe(struct platform_device *pdev)
        priv->regmap = map;
 
        priv->phy = devm_phy_create(dev, np, &phy_axg_mipi_pcie_analog_ops);
-       if (IS_ERR(priv->phy)) {
-               ret = PTR_ERR(priv->phy);
-               if (ret != -EPROBE_DEFER)
-                       dev_err(dev, "failed to create PHY\n");
-               return ret;
-       }
+       if (IS_ERR(priv->phy))
+               return dev_err_probe(dev, PTR_ERR(priv->phy),
+                                    "failed to create PHY\n");
 
        phy_set_drvdata(priv->phy, priv);
        dev_set_drvdata(dev, priv);