]> git.ipfire.org Git - thirdparty/asterisk.git/commitdiff
chan_sip: remove unnecessary ast_channel_unlock(peer) as RAII looks after it
authoralecdavis <sivad.a@paradise.net.nz>
Tue, 21 Aug 2018 23:45:33 +0000 (11:45 +1200)
committerAlec Davis <sivad.a@paradise.net.nz>
Tue, 21 Aug 2018 23:53:05 +0000 (18:53 -0500)
Otherwise console output

        (get_refer_info): mutex 'peer' freed more times than we've locked!
        (get_refer_info): Error releasing mutex: Operation not permitted

    or
        (get_refer_info): attempted unlock mutex 'peer' without owning it!
        (__ast_read): 'peer' was locked here.
        ...dump_backtrace

        (get_refer_info): Error releasing mutex: Operation not permitted
        (__ast_read): mutex 'chan' freed more times than we've locked!

ASTERISK-28011 #close

Change-Id: I6e45f2764ba4f3273a943300f91ac9b461ac2893

channels/chan_sip.c

index ad064220b74e19e2b872f8e2173b5d3e04b46950..de613435711be29542abbbadb43199ee07481711 100644 (file)
@@ -18740,7 +18740,6 @@ static int get_refer_info(struct sip_pvt *transferer, struct sip_request *outgoi
                                S_OR(transferer->context, NULL));
                        pbx_builtin_setvar_helper(peer, "__SIPREFERREDBYHDR",
                                S_OR(p_referred_by, NULL));
-                       ast_channel_unlock(peer);
                }
 
                owner_relock = sip_pvt_lock_full(transferer);