lxccontainer: create_partial()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

diff --git a/src/lxc/lxccontainer.c b/src/lxc/lxccontainer.c
index 5884a7a7c3781a456e9b52c11552276df6bef4d2..673b6ed2ccb1de3c41abf1ae50f06b019479ff6a 100644 (file)
--- a/src/lxc/lxccontainer.c
+++ b/src/lxc/lxccontainer.c
@@ -206,19 +206,21 @@ static int create_partial(struct lxc_container *c)
 
 static void remove_partial(struct lxc_container *c, int fd)
 {
-       // $lxcpath + '/' + $name + '/partial' + \0
-       int len = strlen(c->config_path) + strlen(c->name) + 10;
-       char *path = alloca(len);
        int ret;
+       size_t len;
+       char *path;
 
        close(fd);
+       /* $lxcpath + '/' + $name + '/partial' + \0 */
+       len = strlen(c->config_path) + strlen(c->name) + 10;
+       path = alloca(len);
        ret = snprintf(path, len, "%s/%s/partial", c->config_path, c->name);
-       if (ret < 0 || ret >= len) {
-               ERROR("Error writing partial pathname");
+       if (ret < 0 || (size_t)ret >= len)
                return;
-       }
-       if (unlink(path) < 0)
-               SYSERROR("Error unlink partial file %s", path);
+
+       ret = unlink(path);
+       if (ret < 0)
+               SYSERROR("Failed to remove partial file %s", path);
 }
 
 /* LOCKING