crypto: atmel-sha204a - Fix uninitialized data access on OTP read error

Return early if atmel_i2c_send_receive() fails to avoid checking
potentially uninitialized data in 'cmd.data'.

Cc: stable@vger.kernel.org
Fixes: e05ce444e9e5 ("crypto: atmel-sha204a - add reading from otp zone")
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/atmel-sha204a.c b/drivers/crypto/atmel-sha204a.c
index 72c9d74d3062ef68195fec4e82b19be7d6f79c17..f9c7a4206774bac368cab78b7278ac47b9818d43 100644 (file)
--- a/drivers/crypto/atmel-sha204a.c
+++ b/drivers/crypto/atmel-sha204a.c
@@ -106,6 +106,10 @@ static int atmel_sha204a_otp_read(struct i2c_client *client, u16 addr, u8 *otp)
        }
 
        ret = atmel_i2c_send_receive(client, &cmd);
+       if (ret < 0) {
+               dev_err(&client->dev, "failed to read otp at %04X\n", addr);
+               return ret;
+       }
 
        if (cmd.data[0] == 0xff) {
                dev_err(&client->dev, "failed, device not ready\n");