]> git.ipfire.org Git - thirdparty/dbus.git/commitdiff
_dbus_credentials_to_string_append: Remove useless join = FALSE
authorSimon McVittie <smcv@collabora.com>
Tue, 16 Jan 2018 13:15:34 +0000 (13:15 +0000)
committerSimon McVittie <smcv@collabora.com>
Fri, 2 Mar 2018 14:51:44 +0000 (14:51 +0000)
It can't actually matter in practice, because we never know the
Unix uid and Unix groups but not pid, and we never have a Windows SID
and also a Linux security label; but resetting join to FALSE can only
ever result in us outputting something like "foo=123bar=456" instead
of the intended form with a space in the middle.

Signed-off-by: Simon McVittie <smcv@collabora.com>
Reviewed-by: Philip Withnall <withnall@endlessm.com>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=103737

dbus/dbus-credentials.c

index 63c4b90fd48247ce0d2a4823bafb07356890b03f..927f79d5f13e59ec4c45f0a28b047e064c9bdf41 100644 (file)
@@ -681,8 +681,6 @@ _dbus_credentials_to_string_append (DBusCredentials    *credentials,
         goto oom;
       join = TRUE;
     }
-  else
-    join = FALSE;
 
   if (credentials->unix_gids != NULL)
     {
@@ -705,8 +703,6 @@ _dbus_credentials_to_string_append (DBusCredentials    *credentials,
         goto oom;
       join = TRUE;
     }
-  else
-    join = FALSE;
 
   if (credentials->linux_security_label != NULL)
     {