]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
media: ccs-pll: Print PLL calculator flags in the beginning
authorSakari Ailus <sakari.ailus@linux.intel.com>
Wed, 5 Mar 2025 11:30:41 +0000 (13:30 +0200)
committerHans Verkuil <hverkuil@xs4all.nl>
Fri, 25 Apr 2025 08:15:18 +0000 (10:15 +0200)
Print the PLL calculator flags right away when the PLL calculator is
called. Previously this was done only in a successful case and that didn't
really help solving a problem when one happened.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/i2c/ccs-pll.c

index 8de8158a413bcbdfb28d0225bc7d5eb3a7621f47..87798616b76d4fff0f6085b436233b7c1faf63bb 100644 (file)
@@ -123,8 +123,11 @@ static void print_pll(struct device *dev, const struct ccs_pll *pll)
                pll->pixel_rate_pixel_array);
        dev_dbg(dev, "pixel rate on CSI-2 bus:\t%u\n",
                pll->pixel_rate_csi);
+}
 
-       dev_dbg(dev, "flags%s%s%s%s%s%s%s%s%s%s%s\n",
+static void print_pll_flags(struct device *dev, struct ccs_pll *pll)
+{
+       dev_dbg(dev, "PLL flags%s%s%s%s%s%s%s%s%s%s%s\n",
                pll->flags & PLL_FL(OP_PIX_CLOCK_PER_LANE) ? " op-pix-clock-per-lane" : "",
                pll->flags & PLL_FL(NO_OP_CLOCKS) ? " no-op-clocks" : "",
                pll->flags & PLL_FL(EVEN_PLL_MULTIPLIER) ? " even-pll-multiplier" : "",
@@ -738,6 +741,8 @@ int ccs_pll_calculate(struct device *dev, const struct ccs_pll_limits *lim,
        u32 i;
        int rval = -EINVAL;
 
+       print_pll_flags(dev, pll);
+
        if (!(pll->flags & CCS_PLL_FLAG_LANE_SPEED_MODEL)) {
                pll->op_lanes = 1;
                pll->vt_lanes = 1;