]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
gfs2: document ip in __gfs2_holder_init kernel-doc comment
authorSukrut Heroorkar <hsukrut3@gmail.com>
Mon, 27 Oct 2025 11:00:41 +0000 (16:30 +0530)
committerAndreas Gruenbacher <agruenba@redhat.com>
Fri, 31 Oct 2025 21:04:17 +0000 (21:04 +0000)
Building with W=1 reports:
Warning: fs/gfs2/glock.c:1248 function parameter 'ip' not described
in '__gfs2_holder_init'

The ip parameter was added when __gfs2_holder_init started saving the
gfs2_glock_nq_init caller's return address to gh_ip. This makes it
easier to backtrack which holder took the lock. Document @ip to silence
this warning.

Fixes: b016d9a84abd ("gfs2: Save ip from gfs2_glock_nq_init")
Signed-off-by: Sukrut Heroorkar <hsukrut3@gmail.com>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
fs/gfs2/glock.c

index b677c0e6b9ab3092c87017f9e60173d03fe333df..938bda75a338ec8aee0899824ab0cc4d5b50324a 100644 (file)
@@ -1241,7 +1241,7 @@ found:
  * @state: the state we're requesting
  * @flags: the modifier flags
  * @gh: the holder structure
- *
+ * @ip: caller's return address for debugging
  */
 
 void __gfs2_holder_init(struct gfs2_glock *gl, unsigned int state, u16 flags,