]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
BUG/MINOR: quic: Do not check the acception of a new conn from I/O handler.
authorFrédéric Lécaille <flecaille@haproxy.com>
Fri, 28 May 2021 08:25:07 +0000 (10:25 +0200)
committerAmaury Denoyelle <adenoyelle@haproxy.com>
Thu, 23 Sep 2021 13:27:25 +0000 (15:27 +0200)
As the ->conn member of quic_conn struct is reset to NULL value by the ->accept
callback potentially run by another thread, this check is irrelevant.

src/xprt_quic.c

index 633767a1a2b30c06d6aa1d86516b037570238292..6e2fde9b58fa9b1fb15e7ea7f72aaf2611773312 100644 (file)
@@ -3267,11 +3267,6 @@ static ssize_t qc_lstnr_pkt_rcv(unsigned char **buf, const unsigned char *end,
                        LIST_APPEND(&l->rx.qpkts, &pkt->rx_list);
                        /* Try to accept a new connection. */
                        listener_accept(l);
-                       if (!qc->conn) {
-                               TRACE_PROTO("Non accepted connection", QUIC_EV_CONN_LPKT, qc->conn);
-                               goto err;
-                       }
-
                        if (!quic_conn_init_timer(qc)) {
                                TRACE_PROTO("Non initialized timer", QUIC_EV_CONN_LPKT, qc->conn);
                                goto err;