]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu-slirp: drop unneeded check for OOM
authorMarc-André Lureau <marcandre.lureau@redhat.com>
Sun, 16 Mar 2025 08:18:24 +0000 (12:18 +0400)
committerMartin Kletzander <mkletzan@redhat.com>
Tue, 18 Mar 2025 13:15:55 +0000 (14:15 +0100)
glib anti-pattern, since it aborts on OOM.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
src/qemu/qemu_slirp.c

index 66d9d77c6c43053ee96b09ac0f7a149d4e5614eb..eac7e4cc475c007470d1420dae4a9035ab96dc00 100644 (file)
@@ -99,12 +99,6 @@ qemuSlirpNewForHelper(const char *helper)
     size_t i, nfeatures;
 
     slirp = qemuSlirpNew();
-    if (!slirp) {
-        virReportError(VIR_ERR_INTERNAL_ERROR,
-                       _("Failed to allocate slirp for '%1$s'"), helper);
-        return NULL;
-    }
-
     cmd = virCommandNewArgList(helper, "--print-capabilities", NULL);
     virCommandSetOutputBuffer(cmd, &output);
     if (virCommandRun(cmd, NULL) < 0)