]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virDomainBackupDefParse: Use virXMLProp*
authorTim Wiederhake <twiederh@redhat.com>
Wed, 21 Apr 2021 12:08:00 +0000 (14:08 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 21 Apr 2021 13:13:00 +0000 (15:13 +0200)
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
src/conf/backup_conf.c

index e4464b91a008f3021c706d740bd6dcecc847e7c3..7f176b783f84958059da2a0a2f25441e84f47050 100644 (file)
@@ -222,8 +222,6 @@ virDomainBackupDefParse(xmlXPathContextPtr ctxt,
     def->incremental = virXPathString("string(./incremental)", ctxt);
 
     if ((node = virXPathNode("./server", ctxt))) {
-        g_autofree char *tls = NULL;
-
         if (def->type != VIR_DOMAIN_BACKUP_TYPE_PULL) {
             virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                            _("use of <server> requires pull mode backup"));
@@ -249,18 +247,9 @@ virDomainBackupDefParse(xmlXPathContextPtr ctxt,
             return NULL;
         }
 
-        if ((tls = virXMLPropString(node, "tls"))) {
-            int tmp;
-
-            if ((tmp = virTristateBoolTypeFromString(tls)) <= 0) {
-                virReportError(VIR_ERR_XML_ERROR,
-                               _("unknown value '%s' of 'tls' attribute"),\
-                               tls);
-                return NULL;
-            }
-
-            def->tls = tmp;
-        }
+        if (virXMLPropTristateBool(node, "tls", VIR_XML_PROP_NONE,
+                                   &def->tls) < 0)
+            return NULL;
     }
 
     if ((n = virXPathNodeSet("./disks/*", ctxt, &nodes)) < 0)