Separate visiting operands from visiting binary expression

2008-11-30  Jürg Billeter  <j@bitron.ch>

	* vala/valabinaryexpression.vala:
	* vala/valasymbolresolver.vala:
	* gobject/valaccodebasemodule.vala:

	Separate visiting operands from visiting binary expression

svn path=/trunk/; revision=2094

diff --git a/ChangeLog b/ChangeLog
index 695543999be8b461d2d9048e9ea892773b80d9f4..5b7e7bbb7d10729b2cca99295d2eaba2a9f6ebaa 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2008-11-30  Jürg Billeter  <j@bitron.ch>
+
+       * vala/valabinaryexpression.vala:
+       * vala/valasymbolresolver.vala:
+       * gobject/valaccodebasemodule.vala:
+
+       Separate visiting operands from visiting binary expression
+
 2008-11-30  Jürg Billeter  <j@bitron.ch>
 
        * vala/valadeclarationstatement.vala:

diff --git a/gobject/valaccodebasemodule.vala b/gobject/valaccodebasemodule.vala
index e82d468ada42371cea5f86e7b60035b5f8b2e990..1cb5f83e914b258583a208908ce8039b4d26273a 100644 (file)
--- a/gobject/valaccodebasemodule.vala
+++ b/gobject/valaccodebasemodule.vala
@@ -2743,6 +2743,8 @@ public class Vala.CCodeBaseModule : CCodeModule {
        }
 
        public override void visit_binary_expression (BinaryExpression expr) {
+               expr.accept_children (codegen);
+
                var cleft = (CCodeExpression) expr.left.ccodenode;
                var cright = (CCodeExpression) expr.right.ccodenode;
                

diff --git a/vala/valabinaryexpression.vala b/vala/valabinaryexpression.vala
index 024ec9dcb52ec1f7ce9cc0592758f70a2155e87d..3eb02fd41eb529dee526797789aeb4e4d1a67e45 100644 (file)
--- a/vala/valabinaryexpression.vala
+++ b/vala/valabinaryexpression.vala
@@ -77,16 +77,18 @@ public class Vala.BinaryExpression : Expression {
                right = _right;
                source_reference = source;
        }
-       
-       public override void accept (CodeVisitor visitor) {
-               left.accept (visitor);
-               right.accept (visitor);                 
 
+       public override void accept (CodeVisitor visitor) {
                visitor.visit_binary_expression (this);
 
                visitor.visit_expression (this);
        }
 
+       public override void accept_children (CodeVisitor visitor) {
+               left.accept (visitor);
+               right.accept (visitor);                 
+       }
+
        public override void replace_expression (Expression old_node, Expression new_node) {
                if (left == old_node) {
                        left = new_node;

diff --git a/vala/valasymbolresolver.vala b/vala/valasymbolresolver.vala
index 1bd6829563d1dde6504d0cf37b8c3cb5fd04110e..8f8452a5d3bcfcbe83bcc24882a8984848a377e9 100644 (file)
--- a/vala/valasymbolresolver.vala
+++ b/vala/valasymbolresolver.vala
@@ -410,6 +410,10 @@ public class Vala.SymbolResolver : CodeVisitor {
                expr.accept_children (this);
        }
 
+       public override void visit_binary_expression (BinaryExpression expr) {
+               expr.accept_children (this);
+       }
+
        public override void visit_lambda_expression (LambdaExpression l) {
                l.accept_children (this);
        }