]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
auth NOTIFY: log names of NSes we could not resolve
authorPeter van Dijk <peter.van.dijk@powerdns.com>
Mon, 5 Jul 2021 09:25:40 +0000 (11:25 +0200)
committerPeter van Dijk <peter.van.dijk@powerdns.com>
Thu, 30 Sep 2021 09:53:44 +0000 (11:53 +0200)
pdns/mastercommunicator.cc

index d386a956d48183f4e56c6f96bc5bc63e9923ddcf..7bd71f476f1096cbdb7b48982bb753bbe0257e92 100644 (file)
@@ -58,15 +58,16 @@ void CommunicatorClass::queueNotifyDomain(const DomainInfo& di, UeberBackend* B)
       nsset.insert(getRR<NSRecordContent>(rr.dr)->getNS().toString());
 
     for(const auto & j : nsset) {
-      vector<string> nsips=fns.lookup(DNSName(j), B);
+      auto dnsj = DNSName(j);
+      vector<string> nsips=fns.lookup(dnsj, B);
       if(nsips.empty())
-        g_log<<Logger::Warning<<"Unable to queue notification of domain '"<<di.zone<<"': nameservers do not resolve!"<<endl;
+        g_log<<Logger::Warning<<"Unable to queue notification of domain '"<<di.zone<<"' to nameserver '"<<dnsj<<"': nameserver does not resolve!"<<endl;
       else
         for(const auto & nsip : nsips) {
           const ComboAddress caIp(nsip, 53);
           if(!d_preventSelfNotification || !AddressIsUs(caIp)) {
             if(!d_onlyNotify.match(&caIp))
-              g_log<<Logger::Notice<<"Skipped notification of domain '"<<di.zone<<"' to "<<j<<" because it does not match only-notify."<<endl;
+              g_log<<Logger::Notice<<"Skipped notification of domain '"<<di.zone<<"' to "<<dnsj<<" because "<<caIp<<" does not match only-notify."<<endl;
             else
               ips.insert(caIp.toStringWithPort());
           }