ata: libata-core: Add 'external' to the libata.force kernel parameter

Commit ae1f3db006b7 ("ata: ahci: do not enable LPM on external ports")
changed so that LPM is not enabled on external ports (hotplug-capable or
eSATA ports).

This is because hotplug and LPM are mutually exclusive, see 7.3.1 Hot Plug
Removal Detection and Power Management Interaction in AHCI 1.3.1.

This does require that firmware has set the appropate bits (HPCP or ESP)
in PxCMD (which is a per port register in the AHCI controller).

If the firmware has failed to mark a port as hotplug-capable or eSATA in
PxCMD, then there is currently not much a user can do.

If LPM is enabled on the port, hotplug insertions and removals will not be
detected on that port.

In order to allow a user to fix up broken firmware, add 'external' to the
libata.force kernel parameter.

libata.force can be specified either on the kernel command line, or as a
kernel module parameter.

For more information, see Documentation/admin-guide/kernel-parameters.txt.

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Link: https://lore.kernel.org/r/20250130133544.219297-4-cassel@kernel.org
Signed-off-by: Niklas Cassel <cassel@kernel.org>

diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index fb8752b42ec8582b8750d7e014c4d76166fa2fc1..aa7447f8837cb79d33a8ae831cac4e206a49df03 100644 (file)
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -3116,6 +3116,8 @@
                        * max_sec_lba48: Set or clear transfer size limit to
                          65535 sectors.
 
+                       * external: Mark port as external (hotplug-capable).
+
                        * [no]lpm: Enable or disable link power management.
 
                        * [no]setxfer: Indicate if transfer speed mode setting

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 63ec2f218431900ba2e130eb0efda2bcc9a9a283..9c4a21e5a8bb7953abb37df04009c7ad33fd2acc 100644 (file)
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -88,6 +88,7 @@ struct ata_force_param {
        unsigned int    xfer_mask;
        unsigned int    quirk_on;
        unsigned int    quirk_off;
+       unsigned int    pflags_on;
        u16             lflags_on;
        u16             lflags_off;
 };
@@ -331,6 +332,35 @@ void ata_force_cbl(struct ata_port *ap)
        }
 }
 
+/**
+ *     ata_force_pflags - force port flags according to libata.force
+ *     @ap: ATA port of interest
+ *
+ *     Force port flags according to libata.force and whine about it.
+ *
+ *     LOCKING:
+ *     EH context.
+ */
+static void ata_force_pflags(struct ata_port *ap)
+{
+       int i;
+
+       for (i = ata_force_tbl_size - 1; i >= 0; i--) {
+               const struct ata_force_ent *fe = &ata_force_tbl[i];
+
+               if (fe->port != -1 && fe->port != ap->print_id)
+                       continue;
+
+               /* let pflags stack */
+               if (fe->param.pflags_on) {
+                       ap->pflags |= fe->param.pflags_on;
+                       ata_port_notice(ap,
+                                       "FORCE: port flag 0x%x forced -> 0x%x\n",
+                                       fe->param.pflags_on, ap->pflags);
+               }
+       }
+}
+
 /**
  *     ata_force_link_limits - force link limits according to libata.force
  *     @link: ATA link of interest
@@ -486,6 +516,7 @@ static void ata_force_quirks(struct ata_device *dev)
        }
 }
 #else
+static inline void ata_force_pflags(struct ata_port *ap) { }
 static inline void ata_force_link_limits(struct ata_link *link) { }
 static inline void ata_force_xfermask(struct ata_device *dev) { }
 static inline void ata_force_quirks(struct ata_device *dev) { }
@@ -5456,6 +5487,8 @@ struct ata_port *ata_port_alloc(struct ata_host *host)
 #endif
        ata_sff_port_init(ap);
 
+       ata_force_pflags(ap);
+
        return ap;
 }
 EXPORT_SYMBOL_GPL(ata_port_alloc);
@@ -6268,6 +6301,9 @@ EXPORT_SYMBOL_GPL(ata_platform_remove_one);
        { "no" #name,   .lflags_on      = (flags) },    \
        { #name,        .lflags_off     = (flags) }
 
+#define force_pflag_on(name, flags)                    \
+       { #name,        .pflags_on      = (flags) }
+
 #define force_quirk_on(name, flag)                     \
        { #name,        .quirk_on       = (flag) }
 
@@ -6327,6 +6363,8 @@ static const struct ata_force_param force_tbl[] __initconst = {
        force_lflag_on(rstonce,         ATA_LFLAG_RST_ONCE),
        force_lflag_onoff(dbdelay,      ATA_LFLAG_NO_DEBOUNCE_DELAY),
 
+       force_pflag_on(external,        ATA_PFLAG_EXTERNAL),
+
        force_quirk_onoff(ncq,          ATA_QUIRK_NONCQ),
        force_quirk_onoff(ncqtrim,      ATA_QUIRK_NO_NCQ_TRIM),
        force_quirk_onoff(ncqati,       ATA_QUIRK_NO_NCQ_ON_ATI),