]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
media: nxp: imx8-isi: Use dev_err_probe() to simplify code
authorFrank Li <Frank.Li@nxp.com>
Thu, 22 May 2025 17:56:44 +0000 (13:56 -0400)
committerHans Verkuil <hverkuil@xs4all.nl>
Wed, 18 Jun 2025 07:21:59 +0000 (09:21 +0200)
Use dev_err_probe() simplify code. No functional changes intended.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
Link: https://lore.kernel.org/r/20250522-8qxp_camera-v5-6-d4be869fdb7e@nxp.com
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c

index 073ea5912de3b41a20c6b8e51902375c495e07b4..4ab2749e460d0f526e5f896dab4e3c2533c3108c 100644 (file)
@@ -428,19 +428,16 @@ static int mxc_isi_probe(struct platform_device *pdev)
                return dev_err_probe(dev, isi->num_clks, "Failed to get clocks\n");
 
        isi->regs = devm_platform_ioremap_resource(pdev, 0);
-       if (IS_ERR(isi->regs)) {
-               dev_err(dev, "Failed to get ISI register map\n");
-               return PTR_ERR(isi->regs);
-       }
+       if (IS_ERR(isi->regs))
+               return dev_err_probe(dev, PTR_ERR(isi->regs),
+                                    "Failed to get ISI register map\n");
 
        if (isi->pdata->gasket_ops) {
                isi->gasket = syscon_regmap_lookup_by_phandle(dev->of_node,
                                                              "fsl,blk-ctrl");
-               if (IS_ERR(isi->gasket)) {
-                       ret = PTR_ERR(isi->gasket);
-                       dev_err(dev, "failed to get gasket: %d\n", ret);
-                       return ret;
-               }
+               if (IS_ERR(isi->gasket))
+                       return dev_err_probe(dev, PTR_ERR(isi->gasket),
+                                            "failed to get gasket\n");
        }
 
        dma_size = isi->pdata->has_36bit_dma ? 36 : 32;