]> git.ipfire.org Git - thirdparty/dnspython.git/commitdiff
When scanning interfaces with WMI, include networks without a domain. (#999)
authornoopbug <noopbug@users.noreply.github.com>
Wed, 1 Nov 2023 21:20:29 +0000 (16:20 -0500)
committerGitHub <noreply@github.com>
Wed, 1 Nov 2023 21:20:29 +0000 (14:20 -0700)
* When scanning interfaces with WMI, include networks without a domain.

* Ignore networks found via wmi that have no nameservers

---------

Co-authored-by: Me <me@shiranpuri.com>
dns/win32util.py

index b2ca61dae9a0a48bdf7ae73720b4154891cd46b2..3e67c6bb20378ddb9c4b6c6d283ec131e1e5c202 100644 (file)
@@ -51,9 +51,10 @@ if sys.platform == "win32":
                 try:
                     system = wmi.WMI()
                     for interface in system.Win32_NetworkAdapterConfiguration():
-                        if interface.IPEnabled and interface.DNSDomain:
-                            self.info.domain = _config_domain(interface.DNSDomain)
+                        if interface.IPEnabled and interface.DNSServerSearchOrder:
                             self.info.nameservers = list(interface.DNSServerSearchOrder)
+                            if interface.DNSDomain:
+                                self.info.domain = _config_domain(interface.DNSDomain)
                             if interface.DNSDomainSuffixSearchOrder:
                                 self.info.search = [
                                     _config_domain(x)