]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
comedi: ni_atmio16d: Add sanity checks for I/O base address
authorIan Abbott <abbotti@mev.co.uk>
Fri, 30 Jan 2026 16:47:55 +0000 (16:47 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Apr 2026 13:49:39 +0000 (15:49 +0200)
The "ni_atmio16d" driver uses an admin-supplied configuration option
(`it->options[0]`) to configure the I/O port base address of an
AT-MIO-16 o AT-MIO-16D board.  It currently allows any base address to
be configured but the hardware only supports base addresses (configured
by on-board DIP switches) in the range 0 to 0x3E0 on 32-byte boundaries.

Add a sanity check to ensure the device is not configured at an
unsupported base address.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Link: https://patch.msgid.link/20260130170416.49994-31-abbotti@mev.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/comedi/drivers/ni_atmio16d.c

index e5e7cc423c8796f374c959f5e6d1c106c0067ab1..cefa39b5077c62373c750f12284e5c52df87d853 100644 (file)
@@ -574,7 +574,8 @@ static int atmio16d_attach(struct comedi_device *dev,
        struct comedi_subdevice *s;
        int ret;
 
-       ret = comedi_request_region(dev, it->options[0], 0x20);
+       ret = comedi_check_request_region(dev, it->options[0], 0x20,
+                                         0, 0x3ff, 32);
        if (ret)
                return ret;