libcgroup: Fixed potential crash when setting a parameter value

fclose(NULL) dereferences its argument -> sigsegv.

Signed-off-by: Jan Safranek <jsafrane@redhat.com>
Acked-by: Dhaval Giani <dhaval.giani@gmail.com>

diff --git a/src/api.c b/src/api.c
index e443ad50192bf73b2080a6021e607546804eae43..71cec93d492ebd4c74e44c192e9bcd228d802972 100644 (file)
--- a/src/api.c
+++ b/src/api.c
@@ -1313,9 +1313,9 @@ static int cg_set_control_value(char *path, const char *val)
                                        free(tasks_path);
                                        return ECGROUPSUBSYSNOTMOUNTED;
                                }
+                       } else {
+                               fclose(control_file);
                        }
-
-                       fclose(control_file);
                        free(tasks_path);
                        return ECGROUPNOTALLOWED;
                }