]> git.ipfire.org Git - thirdparty/bacula.git/commitdiff
Do not call mac_cleanup() twice when an error is raised
authorAlain Spineux <alain@baculasystems.com>
Thu, 30 Jul 2020 12:33:10 +0000 (14:33 +0200)
committerEric Bollengier <eric@baculasystems.com>
Tue, 1 Mar 2022 14:36:17 +0000 (15:36 +0100)
- mac_cleanup() was called twice when an error was raised in do_mac()

bacula/src/dird/job.c

index 2193173eba0a26df4f8858c7c954ae2ce4c0e317..256be310cec8114e9dbdde9ca147568efdd77682 100644 (file)
@@ -490,10 +490,10 @@ static void *job_thread(void *arg)
       break;
    case JT_COPY:
    case JT_MIGRATE:
-      if (!job_canceled(jcr) && do_mac(jcr)) {
-         do_autoprune(jcr);
-      } else {
+      if (job_canceled(jcr)) {
          mac_cleanup(jcr, JS_ErrorTerminated, JS_ErrorTerminated);
+      } else  if (do_mac(jcr)) {
+         do_autoprune(jcr);
       }
       break;
    default: