]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
driver core: Skip unnecessary work when device doesn't have sync_state()
authorSaravana Kannan <saravanak@google.com>
Fri, 21 Feb 2020 08:05:10 +0000 (00:05 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 25 Mar 2020 15:10:18 +0000 (16:10 +0100)
commit 77036165d8bcf7c7b2a2df28a601ec2c52bb172d upstream.

A bunch of busy work is done for devices that don't have sync_state()
support. Stop doing the busy work.

Signed-off-by: Saravana Kannan <saravanak@google.com>
Link: https://lore.kernel.org/r/20200221080510.197337-4-saravanak@google.com
Cc: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/core.c

index 3306d5ae92a6c0b0aa99ce78c8ed0d1a38a77716..dbb0f9130f42d386ad815d37377782fd2695bb8a 100644 (file)
@@ -718,6 +718,8 @@ static void __device_links_queue_sync_state(struct device *dev,
 {
        struct device_link *link;
 
+       if (!dev_has_sync_state(dev))
+               return;
        if (dev->state_synced)
                return;
 
@@ -819,7 +821,7 @@ late_initcall(sync_state_resume_initcall);
 
 static void __device_links_supplier_defer_sync(struct device *sup)
 {
-       if (list_empty(&sup->links.defer_sync))
+       if (list_empty(&sup->links.defer_sync) && dev_has_sync_state(sup))
                list_add_tail(&sup->links.defer_sync, &deferred_sync);
 }