]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
target/i386/tcg: remove dead code
authorPaolo Bonzini <pbonzini@redhat.com>
Wed, 31 Dec 2025 11:42:54 +0000 (12:42 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Tue, 13 Jan 2026 09:54:28 +0000 (10:54 +0100)
Remove dead code; it arose when I noticed that, because 0x3? opcodes do
have a pop, case 0x32 works just fine as fcomp (even though 0x?2 is fcom):
there is no need to hack the op to 0x03.

Reported by Coverity as CID 1643922.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
target/i386/tcg/translate.c

index 7c444d5006d224c37167a24370c01a3abdbc1f21..460848e4223d9ff1666a7d460c41b97085cf8295 100644 (file)
@@ -2543,9 +2543,6 @@ static void gen_x87(DisasContext *s, X86DecodedInsn *decode)
                 break;
             }
             break;
-            /* map to fcomp; op & 7 == 2 would not pop  */
-            op = 0x03;
-            /* fallthrough */
         case 0x00 ... 0x07: /* fxxx st, sti */
         case 0x22 ... 0x23: /* fcom2 and fcomp3, undocumented ops */
         case 0x32: /* fcomp5, undocumented op */