Remove inappropriate raw_expression_tree_walker() code

It was walking into the ColumnDef->compression field, which is not a
node but a string.  This code is currently not reachable (because the
compression field is only set in situations that don't go through
raw_expression_tree_walker()), but if it had been, this could have
behaved erratically.

diff --git a/src/backend/nodes/nodeFuncs.c b/src/backend/nodes/nodeFuncs.c
index 6029da3ee1fbf98707e236bcf735548f77427cd9..a7080f5cb24473042f3fb9f090d5dfee359bf490 100644 (file)
--- a/src/backend/nodes/nodeFuncs.c
+++ b/src/backend/nodes/nodeFuncs.c
@@ -4011,8 +4011,6 @@ raw_expression_tree_walker(Node *node,
 
                                if (walker(coldef->typeName, context))
                                        return true;
-                               if (walker(coldef->compression, context))
-                                       return true;
                                if (walker(coldef->raw_default, context))
                                        return true;
                                if (walker(coldef->collClause, context))