Move the check for chan->fdno == -1 to after the zombie/hangup check.

Many users were finding that their hung up channels were staying up and
causing 100% CPU usage.

(issue #14723)
Reported by: seadweller
Patches:
      14723_1-4-tip.patch uploaded by mmichelson (license 60)
Tested by: falves11, bamby

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@189277 65c4cc65-6c06-0410-ace0-fbb531ad65f3

diff --git a/main/channel.c b/main/channel.c
index 8ba8c61669261fb448e34a279d04d9dee64a4595..a10412fc70a30ce9ea79b450b6b97195b64c497c 100644 (file)
--- a/main/channel.c
+++ b/main/channel.c
@@ -2047,6 +2047,13 @@ static struct ast_frame *__ast_read(struct ast_channel *chan, int dropaudio)
                goto done;
        }
 
+       /* Stop if we're a zombie or need a soft hangup */
+       if (ast_test_flag(chan, AST_FLAG_ZOMBIE) || ast_check_hangup(chan)) {
+               if (chan->generator)
+                       ast_deactivate_generator(chan);
+               goto done;
+       }
+
        if (chan->fdno == -1) {
 #ifdef AST_DEVMODE
                ast_log(LOG_ERROR, "ast_read() called with no recorded file descriptor.\n");
@@ -2058,13 +2065,6 @@ static struct ast_frame *__ast_read(struct ast_channel *chan, int dropaudio)
                f = &ast_null_frame;
                goto done;
        }
-
-       /* Stop if we're a zombie or need a soft hangup */
-       if (ast_test_flag(chan, AST_FLAG_ZOMBIE) || ast_check_hangup(chan)) {
-               if (chan->generator)
-                       ast_deactivate_generator(chan);
-               goto done;
-       }
        prestate = chan->_state;
 
        /* Read and ignore anything on the alertpipe, but read only