genie: Accept accessibility and async modifiers on "construct" creation methods

Fixes https://gitlab.gnome.org/GNOME/vala/issues/1235

diff --git a/tests/Makefile.am b/tests/Makefile.am
index cf7198fa4069973f135bf3a4f8f595bdb5b46e50..7fab0a41b3cc99ad376de94d71df94ef5ec0d985 100644 (file)
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -1220,6 +1220,7 @@ TESTS = \
        version/since-parameter.test \
        genie/case.gs \
        genie/class.gs \
+       genie/class-abstract.gs \
        genie/class-field.gs \
        genie/class-init.gs \
        genie/class-property.gs \

diff --git a/tests/genie/class-abstract.gs b/tests/genie/class-abstract.gs
new file mode 100644 (file)
index 0000000..b7f894b
--- /dev/null
+++ b/tests/genie/class-abstract.gs
@@ -0,0 +1,12 @@
+init
+       print "abstract class"
+
+class abstract Test
+       a:string
+       construct protected()
+               a = "a"
+
+class abstract Test2
+       b:string
+       construct async protected()
+               b = "b"

diff --git a/vala/valagenieparser.vala b/vala/valagenieparser.vala
index d7f95cda9a1aa9bac30ad684ca59faeaf498b7b4..f074df73d86b7a7205fa64e591019dc4e5b44445 100644 (file)
--- a/vala/valagenieparser.vala
+++ b/vala/valagenieparser.vala
@@ -3696,7 +3696,7 @@ public class Vala.Genie.Parser : CodeVisitor {
                CreationMethod method;
 
                expect (TokenType.CONSTRUCT);
-               parse_member_declaration_modifiers ();
+               var flags = parse_member_declaration_modifiers ();
 
                if (accept (TokenType.OPEN_PARENS)) {
                        /* create default name using class name */
@@ -3728,9 +3728,21 @@ public class Vala.Genie.Parser : CodeVisitor {
                                method.add_error_type (parse_type (true, false));
                        } while (accept (TokenType.COMMA));
                }
-               method.access = SymbolAccessibility.PUBLIC;
+
+               if (ModifierFlags.PRIVATE in flags) {
+                       method.access = SymbolAccessibility.PRIVATE;
+               } else if (ModifierFlags.PROTECTED in flags) {
+                       method.access = SymbolAccessibility.PROTECTED;
+               } else {
+                       method.access = SymbolAccessibility.PUBLIC;
+               }
+
                set_attributes (method, attrs);
 
+               if (ModifierFlags.ASYNC in flags) {
+                       method.coroutine = true;
+               }
+
                if (accept_block ()) {
                        method.body = parse_block ();
                        method.external = false;