Bug 624522: Add support for SourceForge URLs in "see also"

r/a=mkanat

diff --git a/Bugzilla/BugUrl.pm b/Bugzilla/BugUrl.pm
index b64afb3ce28f1108f510583169e37413162beef1..347d8d2324aa8fe2445a54bf7a3f12ab89e93e30 100644 (file)
--- a/Bugzilla/BugUrl.pm
+++ b/Bugzilla/BugUrl.pm
@@ -64,6 +64,7 @@ use constant SUB_CLASSES => qw(
     Bugzilla::BugUrl::JIRA
     Bugzilla::BugUrl::Trac
     Bugzilla::BugUrl::MantisBT
+    Bugzilla::BugUrl::SourceForge
 );
 
 ###############################

diff --git a/Bugzilla/BugUrl/SourceForge.pm b/Bugzilla/BugUrl/SourceForge.pm
new file mode 100644 (file)
index 0000000..fffa96d
--- /dev/null
+++ b/Bugzilla/BugUrl/SourceForge.pm
@@ -0,0 +1,58 @@
+# -*- Mode: perl; indent-tabs-mode: nil -*-
+#
+# The contents of this file are subject to the Mozilla Public
+# License Version 1.1 (the "License"); you may not use this file
+# except in compliance with the License. You may obtain a copy of
+# the License at http://www.mozilla.org/MPL/
+#
+# Software distributed under the License is distributed on an "AS
+# IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
+# implied. See the License for the specific language governing
+# rights and limitations under the License.
+#
+# The Original Code is the Bugzilla Bug Tracking System.
+#
+# The Initial Developer of the Original Code is Tiago Mello
+# Portions created by Tiago Mello are Copyright (C) 2011
+# Tiago Mello. All Rights Reserved.
+#
+# Contributor(s): Tiago Mello <timello@linux.vnet.ibm.com>
+
+package Bugzilla::BugUrl::SourceForge;
+use strict;
+use base qw(Bugzilla::BugUrl);
+
+use Bugzilla::Error;
+use Bugzilla::Util;
+
+###############################
+####        Methods        ####
+###############################
+
+sub should_handle {
+    my ($class, $uri) = @_;
+    return ($uri->authority =~ /^sourceforge.net$/i
+            and $uri->path =~ m|/tracker/|) ? 1 : 0;
+}
+
+sub _check_value {
+    my $class = shift;
+
+    my $uri = $class->SUPER::_check_value(@_);
+
+    # SourceForge tracker URLs have only one form:
+    #  http://sourceforge.net/tracker/?func=detail&aid=111&group_id=111&atid=111
+    if ($uri->query_param('func') eq 'detail' and $uri->query_param('aid')
+        and $uri->query_param('group_id') and $uri->query_param('atid'))
+    {
+        # Remove any # part if there is one.
+        $uri->fragment(undef);
+        return $uri;
+    }
+    else {
+        my $value = $uri->as_string;
+        ThrowUserError('bug_url_invalid', { url => $value });
+    }
+}
+
+1;

diff --git a/template/en/default/global/user-error.html.tmpl b/template/en/default/global/user-error.html.tmpl
index 9808cc0fc96c2bf521ba76c8359e6a42122eb759..47219e3d99486820c2fa4d87c66a81e447998dc1 100644 (file)
--- a/template/en/default/global/user-error.html.tmpl
+++ b/template/en/default/global/user-error.html.tmpl
@@ -258,6 +258,7 @@
         <li>An issue in a JIRA installation.</li>
         <li>A ticket in a Trac installation.</li>
         <li>A b[% %]ug in a MantisBT installation.</li>
+        <li>A b[% %]ug on sourceforge.net.</li>
       </ul>
     [% ELSIF reason == 'id' %]
       There is no valid [% terms.bug %] id in that URL.