]> git.ipfire.org Git - thirdparty/public-inbox.git/commitdiff
spawn: remove stray variable $ndc_err
authorŠtěpán Němec <stepnem@smrk.net>
Mon, 28 Aug 2023 10:42:44 +0000 (12:42 +0200)
committerEric Wong <e@80x24.org>
Mon, 28 Aug 2023 21:32:29 +0000 (21:32 +0000)
Code that could be setting it was removed in 14fa0abdcc7b.
Likewise for the double assignment to $err.

Fixes: 14fa0abdcc7b ("rewrite Linux nodatacow use in pure Perl w/o system")
lib/PublicInbox/Spawn.pm

index 878843a60a8dd1c58383e6437ad3549c453ce7dd..6e33c712d8d2663c857836189315cda399e9a373 100644 (file)
@@ -293,15 +293,12 @@ ALL_LIBC
 use Inline C => $all_libc, BUILD_NOISY => 1;
 EOM
                my $err = $@;
-               my $ndc_err = '';
-               $err = $@;
                open(STDERR, '>&', $olderr) or warn "restore stderr: $!";
                open(STDOUT, '>&', $oldout) or warn "restore stdout: $!";
                if ($err) {
                        seek($fh, 0, SEEK_SET);
                        my @msg = <$fh>;
-                       warn "Inline::C build failed:\n",
-                               $ndc_err, $err, "\n", @msg;
+                       warn "Inline::C build failed:\n", $err, "\n", @msg;
                        $all_libc = undef;
                }
        }