vircgroup: extract virCgroupV1(Set|Get)BlkioDeviceReadIops

Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>

diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
index 206b5f330a7894d51de53dea5bda87319b05b7e1..50b9430ba00b7cdb8f9d3e05d713755655ee46f5 100644 (file)
--- a/src/util/vircgroup.c
+++ b/src/util/vircgroup.c
@@ -1381,19 +1381,7 @@ virCgroupSetBlkioDeviceReadIops(virCgroupPtr group,
                                 const char *path,
                                 unsigned int riops)
 {
-    VIR_AUTOFREE(char *) str = NULL;
-    VIR_AUTOFREE(char *) blkstr = NULL;
-
-    if (!(blkstr = virCgroupGetBlockDevString(path)))
-        return -1;
-
-    if (virAsprintf(&str, "%s%u", blkstr, riops) < 0)
-        return -1;
-
-    return virCgroupSetValueStr(group,
-                                VIR_CGROUP_CONTROLLER_BLKIO,
-                                "blkio.throttle.read_iops_device",
-                                str);
+    VIR_CGROUP_BACKEND_CALL(group, setBlkioDeviceReadIops, -1, path, riops);
 }
 
 
@@ -1513,25 +1501,7 @@ virCgroupGetBlkioDeviceReadIops(virCgroupPtr group,
                                 const char *path,
                                 unsigned int *riops)
 {
-    VIR_AUTOFREE(char *) str = NULL;
-
-    if (virCgroupGetValueForBlkDev(group,
-                                   VIR_CGROUP_CONTROLLER_BLKIO,
-                                   "blkio.throttle.read_iops_device",
-                                   path,
-                                   &str) < 0)
-        return -1;
-
-    if (!str) {
-        *riops = 0;
-    } else if (virStrToLong_ui(str, NULL, 10, riops) < 0) {
-        virReportError(VIR_ERR_INTERNAL_ERROR,
-                       _("Unable to parse '%s' as an integer"),
-                       str);
-        return -1;
-    }
-
-    return 0;
+    VIR_CGROUP_BACKEND_CALL(group, getBlkioDeviceReadIops, -1, path, riops);
 }
 
 /**

diff --git a/src/util/vircgroupbackend.h b/src/util/vircgroupbackend.h
index aef2a87c6106e9ac6da280fff2343ffcef6f2c57..0b7b4db1a42753c85c659c7160a03dbbf14460e0 100644 (file)
--- a/src/util/vircgroupbackend.h
+++ b/src/util/vircgroupbackend.h
@@ -170,6 +170,16 @@ typedef int
                                    const char *path,
                                    unsigned int *weight);
 
+typedef int
+(*virCgroupSetBlkioDeviceReadIopsCB)(virCgroupPtr group,
+                                     const char *path,
+                                     unsigned int riops);
+
+typedef int
+(*virCgroupGetBlkioDeviceReadIopsCB)(virCgroupPtr group,
+                                     const char *path,
+                                     unsigned int *riops);
+
 struct _virCgroupBackend {
     virCgroupBackendType type;
 
@@ -200,6 +210,8 @@ struct _virCgroupBackend {
     virCgroupGetBlkioIoDeviceServicedCB getBlkioIoDeviceServiced;
     virCgroupSetBlkioDeviceWeightCB setBlkioDeviceWeight;
     virCgroupGetBlkioDeviceWeightCB getBlkioDeviceWeight;
+    virCgroupSetBlkioDeviceReadIopsCB setBlkioDeviceReadIops;
+    virCgroupGetBlkioDeviceReadIopsCB getBlkioDeviceReadIops;
 };
 typedef struct _virCgroupBackend virCgroupBackend;
 typedef virCgroupBackend *virCgroupBackendPtr;

diff --git a/src/util/vircgroupv1.c b/src/util/vircgroupv1.c
index 691270bec39a831317dd58a0824d9eb87b6a0e6b..2294961f072663a51e2219169b032b06cc3469c9 100644 (file)
--- a/src/util/vircgroupv1.c
+++ b/src/util/vircgroupv1.c
@@ -1185,6 +1185,54 @@ virCgroupV1GetBlkioDeviceWeight(virCgroupPtr group,
 }
 
 
+static int
+virCgroupV1SetBlkioDeviceReadIops(virCgroupPtr group,
+                                  const char *path,
+                                  unsigned int riops)
+{
+    VIR_AUTOFREE(char *) str = NULL;
+    VIR_AUTOFREE(char *) blkstr = NULL;
+
+    if (!(blkstr = virCgroupGetBlockDevString(path)))
+        return -1;
+
+    if (virAsprintf(&str, "%s%u", blkstr, riops) < 0)
+        return -1;
+
+    return virCgroupSetValueStr(group,
+                                VIR_CGROUP_CONTROLLER_BLKIO,
+                                "blkio.throttle.read_iops_device",
+                                str);
+}
+
+
+static int
+virCgroupV1GetBlkioDeviceReadIops(virCgroupPtr group,
+                                  const char *path,
+                                  unsigned int *riops)
+{
+    VIR_AUTOFREE(char *) str = NULL;
+
+    if (virCgroupGetValueForBlkDev(group,
+                                   VIR_CGROUP_CONTROLLER_BLKIO,
+                                   "blkio.throttle.read_iops_device",
+                                   path,
+                                   &str) < 0)
+        return -1;
+
+    if (!str) {
+        *riops = 0;
+    } else if (virStrToLong_ui(str, NULL, 10, riops) < 0) {
+        virReportError(VIR_ERR_INTERNAL_ERROR,
+                       _("Unable to parse '%s' as an integer"),
+                       str);
+        return -1;
+    }
+
+    return 0;
+}
+
+
 virCgroupBackend virCgroupV1Backend = {
     .type = VIR_CGROUP_BACKEND_TYPE_V1,
 
@@ -1213,6 +1261,8 @@ virCgroupBackend virCgroupV1Backend = {
     .getBlkioIoDeviceServiced = virCgroupV1GetBlkioIoDeviceServiced,
     .setBlkioDeviceWeight = virCgroupV1SetBlkioDeviceWeight,
     .getBlkioDeviceWeight = virCgroupV1GetBlkioDeviceWeight,
+    .setBlkioDeviceReadIops = virCgroupV1SetBlkioDeviceReadIops,
+    .getBlkioDeviceReadIops = virCgroupV1GetBlkioDeviceReadIops,
 };