- [bug] Added ORA-03135 to the never ending

list of oracle "connection lost" errors
[ticket:2388]

diff --git a/CHANGES b/CHANGES
index b09790e64d37b84bf84da197fe29d6014254aded..ba7327399779eb492b751adbd4d35097abdd7888 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -99,6 +99,11 @@ CHANGES
     is on this driver and how SQLAlchemy's
     implementation should adapt.  [ticket:2347]
 
+- oracle
+  - [bug] Added ORA-03135 to the never ending
+    list of oracle "connection lost" errors
+    [ticket:2388]
+
 - Py3K
   - [bug] Fixed inappropriate usage of util.py3k
     flag and renamed it to util.py3k_warning, since 

diff --git a/lib/sqlalchemy/dialects/oracle/cx_oracle.py b/lib/sqlalchemy/dialects/oracle/cx_oracle.py
index a7ce209f49c6ec585fa8b202128763ee42b69d6a..64526d213eb98ea29818aca2f0090dec12e2080b 100644 (file)
--- a/lib/sqlalchemy/dialects/oracle/cx_oracle.py
+++ b/lib/sqlalchemy/dialects/oracle/cx_oracle.py
@@ -695,8 +695,10 @@ class OracleDialect_cx_oracle(OracleDialect):
             # ORA-00028: your session has been killed
             # ORA-03114: not connected to ORACLE
             # ORA-03113: end-of-file on communication channel
+            # ORA-03135: connection lost contact
             # ORA-01033: ORACLE initialization or shutdown in progress
-            return error.code in (28, 3114, 3113, 1033)
+            # TODO: Others ?
+            return error.code in (28, 3114, 3113, 3135, 1033)
         else:
             return False