mm/damon: rename DAMON_MIN_REGION to DAMON_MIN_REGION_SZ

The macro is for the default minimum size of each DAMON region.  There was
a case that a reader was confused if it is the minimum number of total
DAMON regions, which is set on damon_attrs->min_nr_regions.  Make the name
more explicit.

Link: https://lkml.kernel.org/r/20260117175256.82826-8-sj@kernel.org
Signed-off-by: SeongJae Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

diff --git a/include/linux/damon.h b/include/linux/damon.h
index bdca28e15e4017b17ead79aeaaebbba084be207c..5bf8db1d78fe38d36e72a43818fda21848da7c83 100644 (file)
--- a/include/linux/damon.h
+++ b/include/linux/damon.h
@@ -15,7 +15,7 @@
 #include <linux/random.h>
 
 /* Minimal region size.  Every damon_region is aligned by this. */
-#define DAMON_MIN_REGION       PAGE_SIZE
+#define DAMON_MIN_REGION_SZ    PAGE_SIZE
 /* Max priority score for DAMON-based operation schemes */
 #define DAMOS_MAX_SCORE                (99)
 

diff --git a/mm/damon/core.c b/mm/damon/core.c
index ae5b772ceffbeef0e12460746c027213ae789a32..5508bc79417238ba6204dd90aae9320927560aae 100644 (file)
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -553,7 +553,7 @@ struct damon_ctx *damon_new_ctx(void)
        ctx->attrs.max_nr_regions = 1000;
 
        ctx->addr_unit = 1;
-       ctx->min_sz_region = DAMON_MIN_REGION;
+       ctx->min_sz_region = DAMON_MIN_REGION_SZ;
 
        INIT_LIST_HEAD(&ctx->adaptive_targets);
        INIT_LIST_HEAD(&ctx->schemes);

diff --git a/mm/damon/lru_sort.c b/mm/damon/lru_sort.c
index bedb9134d2861ead19e6aa6c2ccf737c0d0b795d..9dde096a906400140433c07d0c1faa944db6da08 100644 (file)
--- a/mm/damon/lru_sort.c
+++ b/mm/damon/lru_sort.c
@@ -298,7 +298,7 @@ static int damon_lru_sort_apply_parameters(void)
        if (!monitor_region_start && !monitor_region_end)
                addr_unit = 1;
        param_ctx->addr_unit = addr_unit;
-       param_ctx->min_sz_region = max(DAMON_MIN_REGION / addr_unit, 1);
+       param_ctx->min_sz_region = max(DAMON_MIN_REGION_SZ / addr_unit, 1);
 
        if (!damon_lru_sort_mon_attrs.sample_interval) {
                err = -EINVAL;

diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c
index 55df43e241c5d1a87bf0f4249dcf2d0435f47e0a..c343622a2f52a5aed3dce3986698f38366ab8ee0 100644 (file)
--- a/mm/damon/reclaim.c
+++ b/mm/damon/reclaim.c
@@ -208,7 +208,7 @@ static int damon_reclaim_apply_parameters(void)
        if (!monitor_region_start && !monitor_region_end)
                addr_unit = 1;
        param_ctx->addr_unit = addr_unit;
-       param_ctx->min_sz_region = max(DAMON_MIN_REGION / addr_unit, 1);
+       param_ctx->min_sz_region = max(DAMON_MIN_REGION_SZ / addr_unit, 1);
 
        if (!damon_reclaim_mon_attrs.aggr_interval) {
                err = -EINVAL;

diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c
index 4de25708b05a5471d7708f72f70e412130de9521..57d36d60f329cfeddc02b4f5ecbfe3bb1be472c0 100644 (file)
--- a/mm/damon/sysfs.c
+++ b/mm/damon/sysfs.c
@@ -1470,7 +1470,7 @@ static int damon_sysfs_apply_inputs(struct damon_ctx *ctx,
        /* addr_unit is respected by only DAMON_OPS_PADDR */
        if (sys_ctx->ops_id == DAMON_OPS_PADDR)
                ctx->min_sz_region = max(
-                               DAMON_MIN_REGION / sys_ctx->addr_unit, 1);
+                               DAMON_MIN_REGION_SZ / sys_ctx->addr_unit, 1);
        err = damon_sysfs_set_attrs(ctx, sys_ctx->attrs);
        if (err)
                return err;

diff --git a/mm/damon/tests/vaddr-kunit.h b/mm/damon/tests/vaddr-kunit.h
index 30dc5459f1d2c058c73f8f927c49853132bdcd11..cfae870178bfd59854d8caf4ed2fccd4f4db5ccd 100644 (file)
--- a/mm/damon/tests/vaddr-kunit.h
+++ b/mm/damon/tests/vaddr-kunit.h
@@ -147,7 +147,7 @@ static void damon_do_test_apply_three_regions(struct kunit *test,
                damon_add_region(r, t);
        }
 
-       damon_set_regions(t, three_regions, 3, DAMON_MIN_REGION);
+       damon_set_regions(t, three_regions, 3, DAMON_MIN_REGION_SZ);
 
        for (i = 0; i < nr_expected / 2; i++) {
                r = __nth_region_of(t, i);

diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c
index 40c73adf1946f12729c287cecc556353e58758ae..83ab3d8c379201621040e5516d9d335a1ef2540b 100644 (file)
--- a/mm/damon/vaddr.c
+++ b/mm/damon/vaddr.c
@@ -19,8 +19,8 @@
 #include "ops-common.h"
 
 #ifdef CONFIG_DAMON_VADDR_KUNIT_TEST
-#undef DAMON_MIN_REGION
-#define DAMON_MIN_REGION 1
+#undef DAMON_MIN_REGION_SZ
+#define DAMON_MIN_REGION_SZ 1
 #endif
 
 /*
@@ -78,7 +78,7 @@ static int damon_va_evenly_split_region(struct damon_target *t,
 
        orig_end = r->ar.end;
        sz_orig = damon_sz_region(r);
-       sz_piece = ALIGN_DOWN(sz_orig / nr_pieces, DAMON_MIN_REGION);
+       sz_piece = ALIGN_DOWN(sz_orig / nr_pieces, DAMON_MIN_REGION_SZ);
 
        if (!sz_piece)
                return -EINVAL;
@@ -161,12 +161,12 @@ next:
                swap(first_gap, second_gap);
 
        /* Store the result */
-       regions[0].start = ALIGN(start, DAMON_MIN_REGION);
-       regions[0].end = ALIGN(first_gap.start, DAMON_MIN_REGION);
-       regions[1].start = ALIGN(first_gap.end, DAMON_MIN_REGION);
-       regions[1].end = ALIGN(second_gap.start, DAMON_MIN_REGION);
-       regions[2].start = ALIGN(second_gap.end, DAMON_MIN_REGION);
-       regions[2].end = ALIGN(prev->vm_end, DAMON_MIN_REGION);
+       regions[0].start = ALIGN(start, DAMON_MIN_REGION_SZ);
+       regions[0].end = ALIGN(first_gap.start, DAMON_MIN_REGION_SZ);
+       regions[1].start = ALIGN(first_gap.end, DAMON_MIN_REGION_SZ);
+       regions[1].end = ALIGN(second_gap.start, DAMON_MIN_REGION_SZ);
+       regions[2].start = ALIGN(second_gap.end, DAMON_MIN_REGION_SZ);
+       regions[2].end = ALIGN(prev->vm_end, DAMON_MIN_REGION_SZ);
 
        return 0;
 }
@@ -259,8 +259,8 @@ static void __damon_va_init_regions(struct damon_ctx *ctx,
                sz += regions[i].end - regions[i].start;
        if (ctx->attrs.min_nr_regions)
                sz /= ctx->attrs.min_nr_regions;
-       if (sz < DAMON_MIN_REGION)
-               sz = DAMON_MIN_REGION;
+       if (sz < DAMON_MIN_REGION_SZ)
+               sz = DAMON_MIN_REGION_SZ;
 
        /* Set the initial three regions of the target */
        for (i = 0; i < 3; i++) {
@@ -299,7 +299,7 @@ static void damon_va_update(struct damon_ctx *ctx)
        damon_for_each_target(t, ctx) {
                if (damon_va_three_regions(t, three_regions))
                        continue;
-               damon_set_regions(t, three_regions, 3, DAMON_MIN_REGION);
+               damon_set_regions(t, three_regions, 3, DAMON_MIN_REGION_SZ);
        }
 }