virsh-completer: Provide completer for numatune --mode

The completer is trivial, just iterate over
virDomainNumatuneMemMode enum and convert each integer into its
string comrade.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>

diff --git a/tools/virsh-completer-domain.c b/tools/virsh-completer-domain.c
index 93e992e9b1ae4134fa8ff9934b6ef0de964f8885..b4e744c1baeec47e660d0ec941d7546c50a808fb 100644 (file)
--- a/tools/virsh-completer-domain.c
+++ b/tools/virsh-completer-domain.c
@@ -37,6 +37,7 @@
 #include "virkeynametable_osx.h"
 #include "virkeynametable_win32.h"
 #include "conf/storage_conf.h"
+#include "conf/numa_conf.h"
 
 char **
 virshDomainNameCompleter(vshControl *ctl,
@@ -1130,3 +1131,22 @@ virshDomainStorageFileFormatCompleter(vshControl *ctl G_GNUC_UNUSED,
 
     return ret;
 }
+
+
+char **
+virshDomainNumatuneModeCompleter(vshControl *ctl G_GNUC_UNUSED,
+                                 const vshCmd *cmd G_GNUC_UNUSED,
+                                 unsigned int flags)
+{
+    char **ret = NULL;
+    size_t i;
+
+    virCheckFlags(0, NULL);
+
+    ret = g_new0(char *, VIR_DOMAIN_NUMATUNE_MEM_LAST + 1);
+
+    for (i = 0; i < VIR_DOMAIN_NUMATUNE_MEM_LAST; i++)
+        ret[i] = g_strdup(virDomainNumatuneMemModeTypeToString(i));
+
+    return ret;
+}

diff --git a/tools/virsh-completer-domain.h b/tools/virsh-completer-domain.h
index ec7909888e5bcb800a145660f141bf50a6b5286b..94bb3b5e5cd35f97114a3646842358374725b23d 100644 (file)
--- a/tools/virsh-completer-domain.h
+++ b/tools/virsh-completer-domain.h
@@ -181,3 +181,8 @@ char **
 virshDomainBlockjobBaseTopCompleter(vshControl *ctl,
                                     const vshCmd *cmd,
                                     unsigned int flags);
+
+char **
+virshDomainNumatuneModeCompleter(vshControl *ctl,
+                                 const vshCmd *cmd,
+                                 unsigned int flags);

diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index c748fe2ba94fd968e7b8da05757f9c8d72a11005..f086c2dd4b5896beec7879faf681a785997b92a1 100644 (file)
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -9407,6 +9407,7 @@ static const vshCmdOptDef opts_numatune[] = {
     VIRSH_COMMON_OPT_DOMAIN_FULL(0),
     {.name = "mode",
      .type = VSH_OT_STRING,
+     .completer = virshDomainNumatuneModeCompleter,
      .help = N_("NUMA mode, one of strict, preferred and interleave \n"
                 "or a number from the virDomainNumatuneMemMode enum")
     },