]> git.ipfire.org Git - thirdparty/freeradius-server.git/commitdiff
Fix issue with memory usage after being released.
authorJorge Pereira <jpereira@freeradius.org>
Fri, 30 Jun 2023 18:52:54 +0000 (15:52 -0300)
committerAlan DeKok <aland@freeradius.org>
Fri, 30 Jun 2023 19:00:02 +0000 (15:00 -0400)
src/modules/rlm_sqlcounter/rlm_sqlcounter.c

index 33d6d053f54787e5208b0491b375fedfb36b97e8..1a3849e49b9f21138ffdba1d89a33e24f042e2b8 100644 (file)
@@ -424,7 +424,6 @@ static unlang_action_t CC_HINT(nonnull) mod_authorize(rlm_rcode_t *p_result, mod
        if (xlat_aeval(request, &expanded, request, query, NULL, NULL) < 0) {
                RETURN_MODULE_FAIL;
        }
-       talloc_free(expanded);
 
        if (sscanf(expanded, "%" PRIu64, &counter) != 1) {
                RDEBUG2("No integer found in result string \"%s\".  May be first session, setting counter to 0",
@@ -432,6 +431,8 @@ static unlang_action_t CC_HINT(nonnull) mod_authorize(rlm_rcode_t *p_result, mod
                counter = 0;
        }
 
+       talloc_free(expanded);
+
        /*
         *      Check if check item > counter
         */