virconf: Report an error in when virConfSetValue() fails

Callers of virConfSetValue() don't report any error, they just
pass the error blindly. Therefore, report an error when
virConfSetValue() is about to fail.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>

diff --git a/src/util/virconf.c b/src/util/virconf.c
index 07ecfc7b57539dd4509099bf34b3e5add47cf772..29b36227911300aef7d11e72c0271fe247990b1d 100644 (file)
--- a/src/util/virconf.c
+++ b/src/util/virconf.c
@@ -1329,6 +1329,9 @@ virConfSetValue(virConf *conf,
     virConfEntry *prev = NULL;
 
     if (value && value->type == VIR_CONF_STRING && value->str == NULL) {
+        virReportError(VIR_ERR_INTERNAL_ERROR,
+                       _("expecting a value for value of type %s"),
+                       virConfTypeToString(VIR_CONF_STRING));
         virConfFreeValue(value);
         return -1;
     }