]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
conf: Annotate that private data for objects are not copied
authorPeter Krempa <pkrempa@redhat.com>
Fri, 1 Jul 2016 14:38:31 +0000 (16:38 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Mon, 11 Jul 2016 07:06:09 +0000 (09:06 +0200)
Our copy functions format and parse XML thus are not able to copy data.
Annotate the private data pointers that this is happening.

src/conf/domain_conf.h

index a1acebe9d4800b7caec33198a176982504f6d472..eb3a5f30f8213713a3b3f96a9d6cb8965e6251c9 100644 (file)
@@ -2404,6 +2404,8 @@ typedef virDomainXMLPrivateDataCallbacks *virDomainXMLPrivateDataCallbacksPtr;
 struct _virDomainXMLPrivateDataCallbacks {
     virDomainXMLPrivateDataAllocFunc  alloc;
     virDomainXMLPrivateDataFreeFunc   free;
+    /* note that private data for devices are not copied when using
+     * virDomainDefCopy and similar functions */
     virDomainXMLPrivateDataNewFunc    diskNew;
     virDomainXMLPrivateDataNewFunc    hostdevNew;
     virDomainXMLPrivateDataFormatFunc format;