]> git.ipfire.org Git - thirdparty/apache/httpd.git/commitdiff
Merge r1850835, r1851552 from trunk
authorChristophe Jaillet <jailletc36@apache.org>
Fri, 15 Feb 2019 16:06:24 +0000 (16:06 +0000)
committerChristophe Jaillet <jailletc36@apache.org>
Fri, 15 Feb 2019 16:06:24 +0000 (16:06 +0000)
   * mod_authn_dbm: clarify returned value (no fuctional change)

Submitted by: jorton, wrowe
Reviewed by: jailletc36, jim, ylavic
Backported by: jailletc36

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1853654 13f79535-47bb-0310-9956-ffa450edef68

modules/aaa/mod_authn_dbm.c

index f4fb73672eeb37dcad8f2bb49a940dce5b6ddfbe..6eae9e052ab455d960fbf06d62d2a5423b5a731a 100644 (file)
@@ -102,7 +102,11 @@ static apr_status_t fetch_dbm_value(const char *dbmtype, const char *dbmfile,
 
     apr_dbm_close(f);
 
-    return rv;
+    /* NOT FOUND is not an error case; this is indicated by a NULL result.
+     * Treat all NULL lookup/error results as success for the simple case 
+     * of auth credential lookup, these are DECLINED in both cases.
+     */
+    return APR_SUCCESS;
 }
 
 static authn_status check_dbm_pw(request_rec *r, const char *user,