gpio: line-mux: remove bits already handled by GPIO core

GPIO core already handles checking the offset against the number of
GPIOs as well as missing any of the GPIO chip callbacks. Remove the
unnecessary bits.

Also, the offset check was off-by-one as reported by Dan.

Fixes: 2b03d9a40cd1 ("gpio: add gpio-line-mux driver")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/all/aV4b6GAGz1zyf8Xy@stanley.mountain/
Tested-by: Jonas Jelonek <jelonek.jonas@gmail.com>
Reviewed-by: Jonas Jelonek <jelonek.jonas@gmail.com>
Link: https://lore.kernel.org/r/20260107085833.17338-1-bartosz.golaszewski@oss.qualcomm.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

diff --git a/drivers/gpio/gpio-line-mux.c b/drivers/gpio/gpio-line-mux.c
index a4f3843062182c6fa22365618ed2f83fa362ee1a..62548fbd3ca04fcafdaae636c9d51ed4a7a30128 100644 (file)
--- a/drivers/gpio/gpio-line-mux.c
+++ b/drivers/gpio/gpio-line-mux.c
@@ -29,9 +29,6 @@ static int gpio_lmux_gpio_get(struct gpio_chip *gc, unsigned int offset)
        struct gpio_lmux *glm = gpiochip_get_data(gc);
        int ret;
 
-       if (offset > gc->ngpio)
-               return -EINVAL;
-
        ret = mux_control_select_delay(glm->mux, glm->gpio_mux_states[offset],
                                       MUX_SELECT_DELAY_US);
        if (ret < 0)
@@ -42,12 +39,6 @@ static int gpio_lmux_gpio_get(struct gpio_chip *gc, unsigned int offset)
        return ret;
 }
 
-static int gpio_lmux_gpio_set(struct gpio_chip *gc, unsigned int offset,
-                             int value)
-{
-       return -EOPNOTSUPP;
-}
-
 static int gpio_lmux_gpio_get_direction(struct gpio_chip *gc,
                                        unsigned int offset)
 {
@@ -80,7 +71,6 @@ static int gpio_lmux_probe(struct platform_device *pdev)
        glm->gc.parent = dev;
 
        glm->gc.get = gpio_lmux_gpio_get;
-       glm->gc.set = gpio_lmux_gpio_set;
        glm->gc.get_direction = gpio_lmux_gpio_get_direction;
 
        glm->mux = devm_mux_control_get(dev, NULL);