scsi: qedf: Add WQ_PERCPU to alloc_workqueue() users

Currently if a user enqueues a work item using schedule_delayed_work()
the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
schedule_work() that is using system_wq and queue_work(), that makes use
again of WORK_CPU_UNBOUND.  This lack of consistency cannot be addressed
without refactoring the API.

alloc_workqueue() treats all queues as per-CPU by default, while unbound
workqueues must opt-in via WQ_UNBOUND.

This default is suboptimal: most workloads benefit from unbound queues,
allowing the scheduler to place worker threads where they’re needed and
reducing noise when CPUs are isolated.

This continues the effort to refactor workqueue APIs, which began with
the introduction of new workqueues and a new alloc_workqueue flag in:

commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")

This change adds a new WQ_PERCPU flag to explicitly request
alloc_workqueue() to be per-cpu when WQ_UNBOUND has not been specified.

With the introduction of the WQ_PERCPU flag (equivalent to !WQ_UNBOUND),
any alloc_workqueue() caller that doesn’t explicitly specify WQ_UNBOUND
must now use WQ_PERCPU.

Once migration is complete, WQ_UNBOUND can be removed and unbound will
become the implicit default.

Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
Link: https://patch.msgid.link/20251107150155.267651-3-marco.crivellari@suse.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
index 6b1ebab36fa35b4467bd09957675aaa2c390fbfd..7792e00800ae3dd09d2fc616f0a4d39fa7c65323 100644 (file)
--- a/drivers/scsi/qedf/qedf_main.c
+++ b/drivers/scsi/qedf/qedf_main.c
@@ -3374,7 +3374,8 @@ retry_probe:
        QEDF_INFO(&(qedf->dbg_ctx), QEDF_LOG_INFO, "qedf->io_mempool=%p.\n",
            qedf->io_mempool);
 
-       qedf->link_update_wq = alloc_workqueue("qedf_%u_link", WQ_MEM_RECLAIM,
+       qedf->link_update_wq = alloc_workqueue("qedf_%u_link",
+                                              WQ_MEM_RECLAIM | WQ_PERCPU,
                                               1, qedf->lport->host->host_no);
        INIT_DELAYED_WORK(&qedf->link_update, qedf_handle_link_update);
        INIT_DELAYED_WORK(&qedf->link_recovery, qedf_link_recovery);
@@ -3585,7 +3586,8 @@ retry_probe:
        ether_addr_copy(params.ll2_mac_address, qedf->mac);
 
        /* Start LL2 processing thread */
-       qedf->ll2_recv_wq = alloc_workqueue("qedf_%d_ll2", WQ_MEM_RECLAIM, 1,
+       qedf->ll2_recv_wq = alloc_workqueue("qedf_%d_ll2",
+                                           WQ_MEM_RECLAIM | WQ_PERCPU, 1,
                                            host->host_no);
        if (!qedf->ll2_recv_wq) {
                QEDF_ERR(&(qedf->dbg_ctx), "Failed to LL2 workqueue.\n");
@@ -3628,7 +3630,8 @@ retry_probe:
        }
 
        qedf->timer_work_queue = alloc_workqueue("qedf_%u_timer",
-                               WQ_MEM_RECLAIM, 1, qedf->lport->host->host_no);
+                               WQ_MEM_RECLAIM | WQ_PERCPU, 1,
+                               qedf->lport->host->host_no);
        if (!qedf->timer_work_queue) {
                QEDF_ERR(&(qedf->dbg_ctx), "Failed to start timer "
                          "workqueue.\n");
@@ -3641,7 +3644,8 @@ retry_probe:
                sprintf(host_buf, "qedf_%u_dpc",
                    qedf->lport->host->host_no);
                qedf->dpc_wq =
-                       alloc_workqueue("%s", WQ_MEM_RECLAIM, 1, host_buf);
+                       alloc_workqueue("%s", WQ_MEM_RECLAIM | WQ_PERCPU, 1,
+                                       host_buf);
        }
        INIT_DELAYED_WORK(&qedf->recovery_work, qedf_recovery_handler);
 
@@ -4177,7 +4181,8 @@ static int __init qedf_init(void)
                goto err3;
        }
 
-       qedf_io_wq = alloc_workqueue("%s", WQ_MEM_RECLAIM, 1, "qedf_io_wq");
+       qedf_io_wq = alloc_workqueue("%s", WQ_MEM_RECLAIM | WQ_PERCPU, 1,
+                                    "qedf_io_wq");
        if (!qedf_io_wq) {
                QEDF_ERR(NULL, "Could not create qedf_io_wq.\n");
                goto err4;