s390/tape: Fix return value of ccw helper functions

In contrast to all other helper functions used to build CCW chains,
tape_ccw_cc_idal() and tape_ccw_end_idal() return values using
post-increments, which results in returning the same CCW pointer.

Though, the intent of the CCW helper functions is to return the _next_
CCW in the chain, which can then be processed.

There is currently no actual issue, as tape_ccw_cc_idal() is not used
yet and tape_ccw_end_idal() is only used at the end of a chain.

Change both functions return statement to ccw + 1 and bring them in line
with the other helper functions.

Signed-off-by: Jan Höppner <hoeppner@linux.ibm.com>
Reviewed-by: Jens Remus <jremus@linux.ibm.com>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>

diff --git a/drivers/s390/char/tape.h b/drivers/s390/char/tape.h
index dc04518b7beca1776ef2991245719914b13e3a99..0596a9758662bbb7480b6cbd334e6b834f08cc92 100644 (file)
--- a/drivers/s390/char/tape.h
+++ b/drivers/s390/char/tape.h
@@ -352,7 +352,7 @@ tape_ccw_cc_idal(struct ccw1 *ccw, __u8 cmd_code, struct idal_buffer *idal)
        ccw->cmd_code = cmd_code;
        ccw->flags    = CCW_FLAG_CC;
        idal_buffer_set_cda(idal, ccw);
-       return ccw++;
+       return ccw + 1;
 }
 
 static inline struct ccw1 *
@@ -361,7 +361,7 @@ tape_ccw_end_idal(struct ccw1 *ccw, __u8 cmd_code, struct idal_buffer *idal)
        ccw->cmd_code = cmd_code;
        ccw->flags    = 0;
        idal_buffer_set_cda(idal, ccw);
-       return ccw++;
+       return ccw + 1;
 }
 
 /* Global vars */